yahoo-eng-team team mailing list archive

[Matt Riedemann <mriedem.os@xxxxxxxxx>]

Public bug reported:

This PCI validation code in the live migration task in conductor is run
per possible dest host for the migration:

https://github.com/openstack/nova/blob/master/nova/conductor/tasks/live_migrate.py#L212-L228

But is host agnostic, meaning if I have 100 possible dest hosts for the
live migration and an instance with a flavor-defined pci request, it's
going to fail that validation the same way 100 times.

That validation should be pulled up to a point before we even start
asking the scheduler for hosts, e.g. like the numa live migration
support:

https://github.com/openstack/nova/blob/master/nova/conductor/tasks/live_migrate.py#L85

** Affects: nova
     Importance: Low
         Status: Triaged


** Tags: conductor live-migration

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1842087

Title:
  _check_can_migrate_pci in the LiveMigrationTask has host agnostic
  validation that is redundant/expensive

Status in OpenStack Compute (nova):
  Triaged

Bug description:
  This PCI validation code in the live migration task in conductor is
  run per possible dest host for the migration:

  https://github.com/openstack/nova/blob/master/nova/conductor/tasks/live_migrate.py#L212-L228

  But is host agnostic, meaning if I have 100 possible dest hosts for
  the live migration and an instance with a flavor-defined pci request,
  it's going to fail that validation the same way 100 times.

  That validation should be pulled up to a point before we even start
  asking the scheduler for hosts, e.g. like the numa live migration
  support:

  https://github.com/openstack/nova/blob/master/nova/conductor/tasks/live_migrate.py#L85

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1842087/+subscriptions