← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1838666] Re: lxml 4.4.0 causes failed tests in nova

 

Reviewed:  https://review.opendev.org/678964
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=58ffff49ac716772b8d67ab487938215f5a0a658
Submitter: Zuul
Branch:    master

commit 58ffff49ac716772b8d67ab487938215f5a0a658
Author: Sean Mooney <work@xxxxxxxxxxxxxxx>
Date:   Tue Aug 27 23:16:38 2019 +0100

    fix lxml compatibility issues
    
    Some unit tests were performing string matches on xml data
    with inputs that were generated using lxml. This is problematic
    as while white space between element tags is important in xml
    ordering of attributes within a tag is not. In the latest version
    of lxml the ordering asserted in the test no longer matches the
    order returned by lxml on python 3.6+.
    
    This change updates the failing test to use the XMLMatcher
    class to compare xml strings instead.
    
    Closes-Bug: #1838666
    Related-Bug: #1841667
    Change-Id: I1649a850ccb9ac85d7a962936ffef51d573b6f78


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1838666

Title:
  lxml 4.4.0 causes failed tests in nova

Status in OpenStack Compute (nova):
  Fix Released
Status in OpenStack Compute (nova) stein series:
  Confirmed

Bug description:
  It looks like it's just a ordering issue for the elements that are
  returned.

  See https://review.opendev.org/673848 for details on the failure (you
  can depend on it for testing fixes as well).

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1838666/+subscriptions


References