← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1843090] [NEW] ComputeTaskManager._cold_migrate could get a legacy request spec dict from stein computes if rpc pinned and not convert it properly

 

Public bug reported:

As of this change in Stein https://review.opendev.org/#/c/582417/ the
compute service will pass a request spec back to conductor when
rescheduling during a resize or cold migration. If the compute RPC API
version is pinned below 5.1, however, that request spec will be a legacy
dict rather than a full RequestSpec object so the code here:

https://github.com/openstack/nova/blob/19.0.0/nova/conductor/manager.py#L302-L321

Needs to account for the legacy dict case.

** Affects: nova
     Importance: Low
     Assignee: Matt Riedemann (mriedem)
         Status: In Progress

** Affects: nova/stein
     Importance: Low
         Status: Triaged


** Tags: conductor upgrade

** Also affects: nova/stein
   Importance: Undecided
       Status: New

** Changed in: nova/stein
       Status: New => Triaged

** Changed in: nova/stein
   Importance: Undecided => Low

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1843090

Title:
  ComputeTaskManager._cold_migrate could get a legacy request spec dict
  from stein computes if rpc pinned and not convert it properly

Status in OpenStack Compute (nova):
  In Progress
Status in OpenStack Compute (nova) stein series:
  Triaged

Bug description:
  As of this change in Stein https://review.opendev.org/#/c/582417/ the
  compute service will pass a request spec back to conductor when
  rescheduling during a resize or cold migration. If the compute RPC API
  version is pinned below 5.1, however, that request spec will be a
  legacy dict rather than a full RequestSpec object so the code here:

  https://github.com/openstack/nova/blob/19.0.0/nova/conductor/manager.py#L302-L321

  Needs to account for the legacy dict case.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1843090/+subscriptions


Follow ups