yahoo-eng-team team mailing list archive

[OpenStack Infra <1842482@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/680001
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=bacc7abf83f18825a49af2c14cebbeb312615c1d
Submitter: Zuul
Branch:    master

commit bacc7abf83f18825a49af2c14cebbeb312615c1d
Author: Slawek Kaplonski <skaplons@xxxxxxxxxx>
Date:   Wed Sep 4 21:50:01 2019 +0200

    Make Neutron gate great again
    
    This is combined patch to fix couple of issues which
    we recently had in gate.
    
    1. [Functional tests] Fix SIGHUP handling tests
    
    Tests in neutron.functional.test_server module are testing how
    PluginWorker, WSGIWorker and RPCWorker are handling SIGHUP signal.
    
    Recently this was changed in Oslo.service with [1] and our tests
    were failing because they were still expecting that after sending
    SIGHUP to the process, stop() and than start() method will be called.
    
    But as our services uses "mutate" as restart method, since [1] such
    process don't executes stop() and start() after SIGHUP. It now executes
    only reset() method.
    This patch reflects that change in Neutron functional tests.
    
    2. Veth pair "IFLA_LINK" populated since kernel 4.15.0-60-generic
    
    Since kernel_version=4.15.0-60-generic, "iproute2" provides the veth
    pair index, even if the pair interface is in other namespace. In
    previous versions, the parameter 'IFLA_LINK' was not present. We need
    to handle both cases
    
    [1] https://review.opendev.org/#/c/641907/
    
    Co-Authored-By: Rodolfo Alonso Hernandez <ralonsoh@xxxxxxxxxx>
    
    Change-Id: I7a3f20a795c89ab1ab037d046a1101cd5c0287d6
    Closes-Bug: #1842659
    Closes-Bug: #1842482


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1842482

Title:
  "test_get_devices_info_veth_different_namespaces" fails because
  veth1_1 interface has a link device in the same namespace

Status in neutron:
  Fix Released

Bug description:
  "test_get_devices_info_veth_different_namespaces" fails because
  veth1_1 interface has a link device in the same namespace:

          
  ft1.2: neutron.tests.functional.privileged.agent.linux.test_ip_lib.GetDevicesInfoTestCase.test_get_devices_info_veth_different_namespacestesttools.testresult.real._StringException: Traceback (most recent call last):
    File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/base.py", line 177, in func
      return f(self, *args, **kwargs)
    File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/functional/privileged/agent/linux/test_ip_lib.py", line 213, in test_get_devices_info_veth_different_namespaces
      self.assertIsNone(ip_lib.get_attr(veth1_1, 'IFLA_LINK'))
    File "/home/zuul/src/opendev.org/openstack/neutron/.tox/dsvm-functional/lib/python3.6/site-packages/testtools/testcase.py", line 426, in assertIsNone
      self.assertThat(observed, matcher, message)
    File "/home/zuul/src/opendev.org/openstack/neutron/.tox/dsvm-functional/lib/python3.6/site-packages/testtools/testcase.py", line 498, in assertThat
      raise mismatch_error
  testtools.matchers._impl.MismatchError: 5 is not None

  
  Log: https://openstack.fortnebula.com:13808/v1/AUTH_e8fd161dc34c421a979a9e6421f823e9/logs_99/679399/6/check/neutron-functional/6f76a3a/testr_results.html.gz

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1842482/+subscriptions