← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1843885] [NEW] Misuse of assertGreaterEqual in a notification functional test

 

Public bug reported:

At [1], there is a misuse of assertGreaterEqual

self.assertGreaterEqual(6, len(fake_notifier.VERSIONED_NOTIFICATIONS),

It should be as follows:

self.assertGreaterEqual(len(fake_notifier.VERSIONED_NOTIFICATIONS), 6

https://github.com/openstack/nova/blob/db5caf2ff8f33e8b3e7f28f041127ee4ac8b1897/nova/tests/functional/notification_sample_tests/test_instance.py#L316-L317 [1]
https://docs.python.org/3/library/unittest.html#unittest.TestCase.assertGreaterEqual

** Affects: nova
     Importance: High
     Assignee: Takashi NATSUME (natsume-takashi)
         Status: In Progress


** Tags: testing

** Changed in: nova
   Importance: Undecided => High

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1843885

Title:
  Misuse of assertGreaterEqual in a notification functional test

Status in OpenStack Compute (nova):
  In Progress

Bug description:
  At [1], there is a misuse of assertGreaterEqual

  self.assertGreaterEqual(6, len(fake_notifier.VERSIONED_NOTIFICATIONS),

  It should be as follows:

  self.assertGreaterEqual(len(fake_notifier.VERSIONED_NOTIFICATIONS), 6

  https://github.com/openstack/nova/blob/db5caf2ff8f33e8b3e7f28f041127ee4ac8b1897/nova/tests/functional/notification_sample_tests/test_instance.py#L316-L317 [1]
  https://docs.python.org/3/library/unittest.html#unittest.TestCase.assertGreaterEqual

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1843885/+subscriptions


Follow ups