yahoo-eng-team team mailing list archive

[OpenStack Infra <1843871@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/681995
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=cd1009bd2f3d6a6ee6e1d00e3733bb9964bb1903
Submitter: Zuul
Branch:    master

commit cd1009bd2f3d6a6ee6e1d00e3733bb9964bb1903
Author: Akihiro Motoki <amotoki@xxxxxxxxx>
Date:   Fri Sep 13 17:38:00 2019 +0900

    Restore horizon.utils.functions.get_page_size()
    
    Commit 7c897b677cc4e7eb11d90fce448160c2b90d1ef4 moved get_page_size
    function from horizon.utils.functions to openstack_dashboard.utils.settings
    (as it is referred by the OpenStack API wrapper).
    
    However, it turns out that many horizon plugins calls the function
    and the above commit breaks horizon plugins.
    
    Considering we are in the last stage of Train development cycle,
    this commit restores horizon.utils.functions.get_page_size()
    to recover horizon plugins.
    
    Change-Id: I61be648b04ab0320a8c03b769e28ed74bbd242a1
    Closes-Bug: #1843871


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1843871

Title:
  Moving get_page_size from horizon to openstack_dashboard breaks many
  horizon plugins

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  Commit 7c897b677cc4e7eb11d90fce448160c2b90d1ef4 (which was merged yesterday, Sep 13) moved horizon.utils.functions.get_page_size to openstack_dashboard.utils.settings as it is specific to openstack_dashboard.
  However, it turns out this change breaks many horizon plugins as they calls get_page_size() to determine the size of pagination in their API calls.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1843871/+subscriptions