yahoo-eng-team team mailing list archive

[OpenStack Infra <1844207@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/679706
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=e224082ecd347202695b8bbc3e5c5253cf729f92
Submitter: Zuul
Branch:    master

commit e224082ecd347202695b8bbc3e5c5253cf729f92
Author: zhufl <zhu.fanglei@xxxxxxxxxx>
Date:   Tue Sep 3 14:53:15 2019 +0800

    Add remote_id definition in _perform_auth
    
    This is to add remote_id definition in _perform_auth, otherwise
    if no remote_id is found, we'll get "NameError: name 'remote_id'
    is not defined" exception.
    
    Change-Id: I2ad7dd6d9e7f74dbeaa87a68472be75b04cef631
    Closes-Bug: #1844207


** Changed in: keystone
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Identity (keystone).
https://bugs.launchpad.net/bugs/1844207

Title:
  _perform_auth may cause NameError exception

Status in OpenStack Identity (keystone):
  Fix Released

Bug description:
  1. Problem
  In function _perform_auth, if no remote_id_name is found, 
  we'll get "NameError: name 'remote_id' is not defined" exception
  when we first use remote_id before definition.

  def _perform_auth(cls, protocol_id):
       idps = PROVIDERS.federation_api.list_idps()
       for idp in idps:
           try:
               remote_id_name = federation_utils.get_remote_id_parameter(
                   idp, protocol_id)
           except exception.FederatedProtocolNotFound:
               # no protocol for this IdP, so this can't be the IdP we're
               # looking for
               continue     
           remote_id = flask.request.environ.get(remote_id_name)
           if remote_id:
               break
       if not remote_id:
           msg = 'Missing entity ID from environment'
           tr_msg = _('Missing entity ID from environment')
           LOG.error(msg)
           raise exception.Unauthorized(tr_msg)

  2. Fix
  Add remote_id definition.

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1844207/+subscriptions