yahoo-eng-team team mailing list archive

[OpenStack Infra <1833721@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/683109
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=2a7030a6b7ae2ab2e24648727bbde91b05de82cc
Submitter: Zuul
Branch:    master

commit 2a7030a6b7ae2ab2e24648727bbde91b05de82cc
Author: Rodolfo Alonso Hernandez <ralonsoh@xxxxxxxxxx>
Date:   Thu Sep 19 10:58:32 2019 +0000

    Change ip_lib decorators order
    
    Change the execution order of:
    - @privileged.default.entrypoint
    - @lockutils.synchronized("privileged-ip-lib")
    
    "synchronized" decorator holds the execution of the function until
    the lock is released. Using the current decorator ordering, this
    active wait is done inside the privsep context. This can exhaust
    the number of execution threads reserved for the privsep daemon.
    
    Closes-Bug: #1833721
    
    Change-Id: Ifcce954003e360f620f9131a36a08ab84cbe6193


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1833721

Title:
  ip_lib synchronized decorator should wrap the privileged one

Status in neutron:
  Fix Released

Bug description:
  In ip_lib library, the methods calling Pyroute commands are decorated with two functions (in this order):
  - @privileged.default.entrypoint
  - @lockutils.synchronized("privileged-ip-lib")

  "synchronized" decorator holds the execution of the function until the
  lock is released. Using the current decorator ordering, this active
  wait is done inside the privsep context. This can exhaust the number
  of execution threads reserved for the privsep daemon.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1833721/+subscriptions