← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1841411] Re: Instances recovered after failed migrations enter error state (hyper-v)

 

Reviewed:  https://review.opendev.org/678481
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=12b361f0b44f3d34899982b643482228044d3d86
Submitter: Zuul
Branch:    master

commit 12b361f0b44f3d34899982b643482228044d3d86
Author: Lucian Petrut <lpetrut@xxxxxxxxxxxxxxxxxxxxxx>
Date:   Mon Aug 26 10:49:22 2019 +0300

    Avoid error state for recovered instances after failed migrations
    
    Most users expect that if a live migration fails but the instance
    is fully recovered, it shouldn't enter 'error' state. Setting
    the migration status to 'error' should be enough. This simplifies
    debugging, making it clear that the instance dosn't have to be
    manually recovered.
    
    This patch changed this behavior, indirectly affecting the Hyper-V
    driver: Idfdce9e7dd8106af01db0358ada15737cb846395
    
    We'll stop propagating exceptions when managing to recover the
    instance, which matches the reference driver (libvirt) behavior.
    
    Change-Id: I16c200ebf0a996865ddce5688434e9c9ad69e331
    Closes-Bug: 1841411


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1841411

Title:
  Instances recovered after failed migrations enter error state
  (hyper-v)

Status in compute-hyperv:
  Fix Released
Status in OpenStack Compute (nova):
  Fix Released
Status in OpenStack Compute (nova) queens series:
  New
Status in OpenStack Compute (nova) rocky series:
  New
Status in OpenStack Compute (nova) stein series:
  Fix Committed

Bug description:
  Most users expect that if a live migration fails but the instance is
  fully recovered, it shouldn't enter 'error' state. Setting the
  migration status to 'error' should be enough. This simplifies
  debugging, making it clear that the instance dosn't have to be
  manually recovered.

  This patch changed this behavior, indirectly affecting the Hyper-V
  driver, which propagates migration errors:
  Idfdce9e7dd8106af01db0358ada15737cb846395

  When using the Hyper-V driver, instances enter error state even after
  successful recoveries. We may copy the Libvirt driver behavior and
  avoid propagating exceptions in this case.

To manage notifications about this bug go to:
https://bugs.launchpad.net/compute-hyperv/+bug/1841411/+subscriptions


References