yahoo-eng-team team mailing list archive

[OpenStack Infra <1846532@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/678991
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=0f9311fae19e4e204cdc601acbe7dafc49c73661
Submitter: Zuul
Branch:    master

commit 0f9311fae19e4e204cdc601acbe7dafc49c73661
Author: Fan Zhang <zh.f@xxxxxxxxxxx>
Date:   Wed Aug 28 11:16:25 2019 +0800

    Fix exception translation when creating volume
    
    Method `nova.volume.cinder.API#create` accepts `size` as the 3rd args,
    but in wrapper of `nova.volume.cinder.translate_volume_exception`, the 3rd
    parameter is volume_id. If we hit cinder exception when creating volumes
    like the response body down below:
    ```
    {"itemNotFound": {"message": "Volume type with name xxx could not be found.",
    "code": 404}}
    ```
    we may get exception in nova compute log like this:
    ```
    BuildAbortException: Build of instance xxx aborted: Volume 40 could not be
    found.
    ```
    actually, `40` is volume size, not voluem id.
    
    This could be a little misleading.
    
    Closes-Bug: #1846532
    
    Change-Id: If5b0c2f28773e0b2fcb008d5251fb69d950ca569
    Signed-off-by: Fan Zhang <zh.f@xxxxxxxxxxx>


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1846532

Title:
  Confusing error message when volume create fails

Status in OpenStack Compute (nova):
  Fix Released
Status in OpenStack Compute (nova) queens series:
  Confirmed
Status in OpenStack Compute (nova) rocky series:
  Confirmed
Status in OpenStack Compute (nova) stein series:
  Confirmed
Status in OpenStack Compute (nova) train series:
  Confirmed

Bug description:
  Method `nova.volume.cinder.API#create` accepts `size` as the 3rd args,
  but in wrapper of `nova.volume.cinder.translate_volume_exception`, the 3rd
  parameter is volume_id. If we hit cinder exception when creating volumes
  like the response body down below:
  ```
  {"itemNotFound": {"message": "Volume type with name xxx could not be found.",
  "code": 404}}
  ```
  we may get exception in nova compute log like this:
  ```
  BuildAbortException: Build of instance xxx aborted: Volume 40 could not be
  found.
  ```
  actually, `40` is volume size, not voluem id.

  This could be a little misleading.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1846532/+subscriptions