yahoo-eng-team team mailing list archive

[OpenStack Infra <1849165@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/689842
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=80385a22ee480a4c9775148d4729ab5d9c52e76d
Submitter: Zuul
Branch:    master

commit 80385a22ee480a4c9775148d4729ab5d9c52e76d
Author: Eric Fried <openstack@xxxxxxxx>
Date:   Mon Oct 21 11:50:25 2019 -0500

    Don't populate resources for not-yet-migrated inst
    
    Per the referenced bug, it is possible for update_available_resource to
    race with a migration such that the migration record exists, but the
    instance's migration context doesn't. In such cases we shouldn't try to
    track the instance's assigned resources on this host (because there
    aren't any yet).
    
    Change-Id: I69f99adfa8c91b50086052ca1b15c55e86ed614d
    Closes-Bug: #1849165


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1849165

Title:
  _populate_assigned_resources raises "TypeError: argument of type
  'NoneType' is not iterable" during active migration

Status in OpenStack Compute (nova):
  Fix Released
Status in OpenStack Compute (nova) train series:
  In Progress

Bug description:
  Seen here:

  https://zuul.opendev.org/t/openstack/build/2b10b4a240b84245bcee3366db93951d/log/logs/screen-n-cpu.txt.gz?severity=4#2675

  Oct 21 13:35:16.977968 ubuntu-bionic-rax-iad-0012404623 nova-
  compute[26938]: ERROR nova.compute.manager [None req-
  dd5ddbad-4234-4288-bbab-2c3d20b7f4ad None None] Error updating
  resources for node ubuntu-bionic-rax-iad-0012404623.: TypeError:
  argument of type 'NoneType' is not iterable

  Oct 21 13:35:16.977968 ubuntu-bionic-rax-iad-0012404623 nova-
  compute[26938]: ERROR nova.compute.manager Traceback (most recent call
  last):

  Oct 21 13:35:16.977968 ubuntu-bionic-rax-iad-0012404623 nova-
  compute[26938]: ERROR nova.compute.manager   File
  "/opt/stack/new/nova/nova/compute/manager.py", line 8925, in
  _update_available_resource_for_node

  Oct 21 13:35:16.977968 ubuntu-bionic-rax-iad-0012404623 nova-
  compute[26938]: ERROR nova.compute.manager     startup=startup)

  Oct 21 13:35:16.977968 ubuntu-bionic-rax-iad-0012404623 nova-
  compute[26938]: ERROR nova.compute.manager   File
  "/opt/stack/new/nova/nova/compute/resource_tracker.py", line 883, in
  update_available_resource

  Oct 21 13:35:16.977968 ubuntu-bionic-rax-iad-0012404623 nova-
  compute[26938]: ERROR nova.compute.manager
  self._update_available_resource(context, resources, startup=startup)

  Oct 21 13:35:16.977968 ubuntu-bionic-rax-iad-0012404623 nova-
  compute[26938]: ERROR nova.compute.manager   File
  "/usr/local/lib/python2.7/dist-
  packages/oslo_concurrency/lockutils.py", line 328, in inner

  Oct 21 13:35:16.977968 ubuntu-bionic-rax-iad-0012404623 nova-
  compute[26938]: ERROR nova.compute.manager     return f(*args,
  **kwargs)

  Oct 21 13:35:16.977968 ubuntu-bionic-rax-iad-0012404623 nova-
  compute[26938]: ERROR nova.compute.manager   File
  "/opt/stack/new/nova/nova/compute/resource_tracker.py", line 965, in
  _update_available_resource

  Oct 21 13:35:16.977968 ubuntu-bionic-rax-iad-0012404623 nova-
  compute[26938]: ERROR nova.compute.manager
  self._populate_assigned_resources(context, instance_by_uuid)

  Oct 21 13:35:16.977968 ubuntu-bionic-rax-iad-0012404623 nova-
  compute[26938]: ERROR nova.compute.manager   File
  "/opt/stack/new/nova/nova/compute/resource_tracker.py", line 482, in
  _populate_assigned_resources

  Oct 21 13:35:16.977968 ubuntu-bionic-rax-iad-0012404623 nova-
  compute[26938]: ERROR nova.compute.manager     if mig.dest_compute ==
  self.host and 'new_resources' in mig_ctx:

  Oct 21 13:35:16.977968 ubuntu-bionic-rax-iad-0012404623 nova-
  compute[26938]: ERROR nova.compute.manager TypeError: argument of type
  'NoneType' is not iterable

  Oct 21 13:35:16.977968 ubuntu-bionic-rax-iad-0012404623 nova-
  compute[26938]: ERROR nova.compute.manager

  This was added late in Train:

  https://review.opendev.org/#/c/678452/

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1849165/+subscriptions