yahoo-eng-team team mailing list archive

[OpenStack Infra <1843639@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/682622
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=ac68cffd43a2f5103c28a2d4b31e087c3f5c24b9
Submitter: Zuul
Branch:    master

commit ac68cffd43a2f5103c28a2d4b31e087c3f5c24b9
Author: Lee Yarwood <lyarwood@xxxxxxxxxx>
Date:   Wed Sep 11 19:24:05 2019 +0100

    libvirt: Ignore volume exceptions during post_live_migration
    
    Previously errors while disconnecting volumes from the source host
    during post_live_migration within LibvirtDriver would result in the
    overall failure of the migration. This would also mean that while the
    instance would be running on the destination it would still be listed as
    running on the source within the db.
    
    This change simply ignores any exceptions raised while attempting to
    disconnect volumes on the source. These errors can be safely ignored as
    they will have no impact on the running instance on the destination.
    
    In the future Nova could wire up the force and ignore_errors kwargs when
    calling down into the associated os-brick connectors to help avoid this.
    
    Closes-Bug: #1843639
    Change-Id: Ieff5243854321ec40f642845e87a0faecaca8721


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1843639

Title:
  libvirt: post_live_migration failures to disconnect volumes result in
  the rollback of live migrations

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  Description
  ===========
  At present any exceptions encountered during post_live_migration on the source after an instance has successfully migrated result in the overall failure of the migration and the instance being listed as running on the source while actually being on the destination.

  Any such errors should be logged but otherwise ignored allowing the
  migration to complete and for the instance to continue to be tracked
  correctly.

  
  Steps to reproduce
  ==================
  - Live migrate an instance from host A to host B, ensuring post_live_migration fails.

  Expected result
  ===============
  Any failures on the source encountered by post_live_migration are logged but the overall migration still completes successfully.

  Actual result
  =============
  The instance and overall migration are left in error states. Additionally the instance is reported as residing on the source host while actually running on the destination.

  Environment
  ===========
  1. Exact version of OpenStack you are running. See the following
    list for all releases: http://docs.openstack.org/releases/

     ba3147420c0a6f8b17a46b1a493b89bcd67af6f1

  2. Which hypervisor did you use?
     (For example: Libvirt + KVM, Libvirt + XEN, Hyper-V, PowerKVM, ...)
     What's the version of that?

     Libvirt + KVM

  2. Which storage type did you use?
     (For example: Ceph, LVM, GPFS, ...)
     What's the version of that?

     N/A

  3. Which networking type did you use?
     (For example: nova-network, Neutron with OpenVSwitch, ...)

     N/A

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1843639/+subscriptions