yahoo-eng-team team mailing list archive

[OpenStack Infra <1852724@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/694505
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=458fd224db8cb263b8872ae8d0b7c893e9fd8de2
Submitter: Zuul
Branch:    master

commit 458fd224db8cb263b8872ae8d0b7c893e9fd8de2
Author: Slawek Kaplonski <skaplons@xxxxxxxxxx>
Date:   Fri Nov 15 11:23:19 2019 +0100

    [Fullstack] Fix waiting for packet with DSCP mark in test
    
    In test_dscp_marking_packets, sender vm is sending ICMP packets to the
    receiver_vm.
    Before this patch even if first ICMP packet wasn't send properly, test
    failed due to exception raised in execute method.
    
    It can happend sometimes that first packet will fail to be send as there
    can be e.g. some configuration on agent's side not done yet. So we
    should try to ping receiver_vm for 60 seconds instead of failing on
    first attempt.
    This patch changes that behaviour in test.
    
    Change-Id: Ic84e1ef507f017516d47a6b66e646e7e7b5ded8d
    Closes-Bug: #1852724


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1852724

Title:
  Fullstack test for dscp_marking_packets fails if first icmp is not
  send properly

Status in neutron:
  Fix Released

Bug description:
  Example of failure:
  https://b56892e10e3e61a452c2-e4b54cf82b19c70bded9dbfe71e9b8f5.ssl.cf2.rackcdn.com/601336/41/check
  /neutron-fullstack/cfd8a8e/testr_results.html.gz

  Stacktrace:
  ft3.2: neutron.tests.fullstack.test_qos.TestDscpMarkingQoSLinuxbridge.test_dscp_marking_packetstesttools.testresult.real._StringException: Traceback (most recent call last):
    File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/base.py", line 181, in func
      return f(self, *args, **kwargs)
    File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/fullstack/test_qos.py", line 498, in test_dscp_marking_packets
      sender, receiver, DSCP_MARK)
    File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/common/agents/l2_extensions.py", line 117, in wait_for_dscp_marked_packet
      time.sleep(0.25)
    File "/usr/lib/python3.6/contextlib.py", line 88, in __exit__
      next(self.gen)
    File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/common/net_helpers.py", line 144, in async_ping
      f.result()
    File "/usr/lib/python3.6/concurrent/futures/_base.py", line 425, in result
      return self.__get_result()
    File "/usr/lib/python3.6/concurrent/futures/_base.py", line 384, in __get_result
      raise self._exception
    File "/usr/lib/python3.6/concurrent/futures/thread.py", line 56, in run
      result = self.fn(*self.args, **self.kwargs)
    File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/common/net_helpers.py", line 127, in assert_async_ping
      dst_ip])
    File "/home/zuul/src/opendev.org/openstack/neutron/neutron/agent/linux/ip_lib.py", line 713, in execute
      run_as_root=run_as_root)
    File "/home/zuul/src/opendev.org/openstack/neutron/neutron/agent/linux/utils.py", line 147, in execute
      returncode=returncode)
  neutron_lib.exceptions.ProcessExecutionError: Exit code: 1; Stdin: ; Stdout: PING 10.0.0.115 (10.0.0.115) 56(84) bytes of data.

  --- 10.0.0.115 ping statistics ---
  1 packets transmitted, 0 received, 100% packet loss, time 0ms

  ; Stderr:

  And it happens even when first ICMP packet isn't send properly from sender to receiver vm.
  We should wait 60 seconds for ICMP packets before fail test.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1852724/+subscriptions