yahoo-eng-team team mailing list archive

[OpenStack Infra <1848220@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/688751
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=59b37701e9e0f07583e92c69537b78e696360997
Submitter: Zuul
Branch:    master

commit 59b37701e9e0f07583e92c69537b78e696360997
Author: Rodolfo Alonso Hernandez <ralonsoh@xxxxxxxxxx>
Date:   Tue Oct 15 16:28:05 2019 +0000

    TestMinBwQoSOvs must call the correct methods
    
    Minimum bandwidth rules and policies set in OVS can be found using
    the methods:
      - OVSBridge._find_qos()
      - OVSBridge._find_queue(port_id)
    
    The methods currently used are incorrect and are not testing correctly
    the real status of the OVS DB.
    
    Change-Id: Ibf2b06439a3cf6a40fec0435b4305a93a5629fd8
    Closes-Bug: #1848220


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1848220

Title:
  TestMinBwQoSOvs is not calling the correct methods

Status in neutron:
  Fix Released

Bug description:
  In fullstack TestMinBwQoSOvs test cases (test_min_bw_qos_port_removed), the methods used to check the Qoses and Queues for min BW are wrong [1]. Methods that should be used:
  - https://github.com/openstack/neutron/blob/master/neutron/agent/common/ovs_lib.py#L1032
  - https://github.com/openstack/neutron/blob/master/neutron/agent/common/ovs_lib.py#L1094

  
  [1] https://github.com/openstack/neutron/blob/9883b58f876042b3f56878a7ba0ba41be6731034/neutron/tests/fullstack/test_qos.py#L693-L694

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1848220/+subscriptions