yahoo-eng-team team mailing list archive

[Thomas Stringer <1854084@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

This commit (https://git.launchpad.net/cloud-
init/commit/?id=4bc399e0cd0b7e9177f948aecd49f6b8323ff30b) has a diff
that includes the removal of passing headers through to readurl from
read_file_or_url: https://github.com/canonical/cloud-
init/commit/4bc399e0cd0b7e9177f948aecd49f6b8323ff30b#diff-
a779470bb47168497ada0a33f7990b01L104

With this commit, the headers parameter is virtually useless (besides
with raising the exception). This has caused us to no longer pass
through headers (https://github.com/canonical/cloud-
init/commit/4bc399e0cd0b7e9177f948aecd49f6b8323ff30b#diff-
a779470bb47168497ada0a33f7990b01L104)  when we make a request using
read_file_or_url (https://github.com/canonical/cloud-
init/blob/master/cloudinit/sources/helpers/azure.py#L186).

** Affects: cloud-init
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to cloud-init.
https://bugs.launchpad.net/bugs/1854084

Title:
  Headers no longer passed through read_file_or_url

Status in cloud-init:
  New

Bug description:
  This commit (https://git.launchpad.net/cloud-
  init/commit/?id=4bc399e0cd0b7e9177f948aecd49f6b8323ff30b) has a diff
  that includes the removal of passing headers through to readurl from
  read_file_or_url: https://github.com/canonical/cloud-
  init/commit/4bc399e0cd0b7e9177f948aecd49f6b8323ff30b#diff-
  a779470bb47168497ada0a33f7990b01L104

  With this commit, the headers parameter is virtually useless (besides
  with raising the exception). This has caused us to no longer pass
  through headers (https://github.com/canonical/cloud-
  init/commit/4bc399e0cd0b7e9177f948aecd49f6b8323ff30b#diff-
  a779470bb47168497ada0a33f7990b01L104)  when we make a request using
  read_file_or_url (https://github.com/canonical/cloud-
  init/blob/master/cloudinit/sources/helpers/azure.py#L186).

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-init/+bug/1854084/+subscriptions