yahoo-eng-team team mailing list archive

[OpenStack Infra <1825018@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/697122
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=0461921d9e5313c3e92b039b90f713ed961e20c8
Submitter: Zuul
Branch:    master

commit 0461921d9e5313c3e92b039b90f713ed961e20c8
Author: Matt Riedemann <mriedem.os@xxxxxxxxx>
Date:   Tue Dec 3 10:54:29 2019 -0500

    Cache security group driver
    
    Change I0932c652fb455fe10239215a93e183ea947234e3 from Mitaka
    was a performance improvement to cache the loaded security
    group driver since the API calls get_openstack_security_group_driver
    a lot. That performance fix was regressed with change
    Ia4a8d9954bf456253101b936f8b4ff513aaa73b2 in Newton.
    
    This caches the loaded security group driver once again. This
    is pretty similar to the original change except simpler since
    we don't have to account for the skip_policy_check flag.
    
    Change-Id: Icacc763f19db6dc90e72af32e17d480775ad5edf
    Closes-Bug: #1825018


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1825018

Title:
  security group driver gets loaded way too much in the api

Status in OpenStack Compute (nova):
  Fix Released
Status in OpenStack Compute (nova) ocata series:
  Confirmed
Status in OpenStack Compute (nova) pike series:
  Confirmed
Status in OpenStack Compute (nova) queens series:
  Confirmed
Status in OpenStack Compute (nova) rocky series:
  Confirmed
Status in OpenStack Compute (nova) stein series:
  Confirmed
Status in OpenStack Compute (nova) train series:
  Confirmed

Bug description:
  There was a fix in Mitaka https://review.openstack.org/#/c/256073/ to
  cache the security group driver once it was loaded per process. That
  cache was removed in Newton https://review.openstack.org/#/c/325684/.
  I put up a test patch to see how many times the security group driver
  gets loaded https://review.openstack.org/#/c/652783/ and in the
  neutron-grenade-multinode job the nova-api logs show it getting loaded
  over 1000 times (browser count hit tops out at 1000). So the fix from
  mitaka was definitely regressed in newton and we should add the driver
  cache code again.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1825018/+subscriptions