yahoo-eng-team team mailing list archive

[OpenStack Infra <1854019@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/696067
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=33fe0fef334ace8b19f1aad78602bb1903806892
Submitter: Zuul
Branch:    master

commit 33fe0fef334ace8b19f1aad78602bb1903806892
Author: Michal Arbet <michal.arbet@xxxxxxxxxx>
Date:   Tue Nov 26 12:15:40 2019 +0100

    Fix failing tests under python3.8
    
    In python3.8 cgi.escape function was removed as it is
    noted here : https://docs.python.org/3/whatsnew/3.8.html
    
    This patch is fixing security_groups tests and replacing
    escape func from cgi to escape func from django.utils.html.
    
    Change-Id: I5e47001dad730b64d4914e72df7d93ee15a1db12
    Closes-Bug: #1854019


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1854019

Title:
  Horizon's tests are failing with python3.8

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  Hi,

  Horizon's tests are failing with python3.8, see below :

  + http_proxy=127.0.0.1:9 https_proxy=127.0.0.9:9 HTTP_PROXY=127.0.0.1:9 HTTPS_PROXY=127.0.0.1:9 PYTHONPATH=/<<PKGBUILDDIR>>/debian/tmp/usr/lib/python3/dist-packages PYTHON=python3.8 python3.8 -m coverage run /<<PKGBUILDDIR>>/manage.py test horizon --verbosity 2 --settings=horizon.test.settings --exclude-tag selenium --exclude-tag integration
  /usr/lib/python3/dist-packages/scss/selector.py:26: FutureWarning: Possible nested set at position 329
    SELECTOR_TOKENIZER = re.compile(r'''
  Creating test database for alias 'default' ('file:memorydb_default?mode=memory&cache=shared')...
  test_legacychoicefield_title (horizon.test.unit.forms.test_fields.ChoiceFieldTests) ... ok
  .
  .
  .
  .
  .
  test_call_functions_parallel_with_kwargs (openstack_dashboard.test.unit.utils.test_futurist_utils.FuturistUtilsTests) ... ok

  ======================================================================
  ERROR: test_detail_invalid_port_range (openstack_dashboard.dashboards.project.security_groups.tests.SecurityGroupsViewTests)
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/<<PKGBUILDDIR>>/openstack_dashboard/test/helpers.py", line 130, in wrapped
      return function(inst, *args, **kwargs)
    File "/<<PKGBUILDDIR>>/openstack_dashboard/dashboards/project/security_groups/tests.py", line 621, in test_detail_invalid_port_range
      self.assertContains(res, cgi.escape('"from" port number is invalid',
  AttributeError: module 'cgi' has no attribute 'escape'

  ----------------------------------------------------------------------
  Ran 1522 tests in 448.635s

  FAILED (errors=1)

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1854019/+subscriptions