yahoo-eng-team team mailing list archive

[sean mooney <smooney@xxxxxxxxxx>]

Public bug reported:

while playing with pre-commit i notice that new versions of flake8 parse type annotion comments.
if you have not imported the relevent typing module then  it fails with F821 undefined name 

nova/virt/hardware.py:1396:5: F821 undefined name 'Optional'
nova/virt/hardware.py:1396:5: F821 undefined name 'List'
nova/virt/hardware.py:1396:5: F821 undefined name 'Set'
nova/virt/hardware.py:1426:5: F821 undefined name 'Optional'
nova/virt/hardware.py:1426:5: F821 undefined name 'List'
nova/virt/hardware.py:1426:5: F821 undefined name 'Set'
nova/virt/hardware.py:1456:5: F821 undefined name 'Optional'
nova/virt/hardware.py:1483:5: F821 undefined name 'Optional'
nova/virt/hardware.py:1525:5: F821 undefined name 'Optional'
nova/virt/hardware.py:1624:5: F821 undefined name 'Tuple'
nova/virt/hardware.py:1646:5: F821 undefined name 'Optional'
nova/virt/hardware.py:1658:5: F821 undefined name 'Optional'
nova/virt/hardware.py:1674:5: F821 undefined name 'List'
nova/virt/hardware.py:1696:5: F821 undefined name 'Optional'
nova/virt/hardware.py:1920:29: F821 undefined name 'List'
nova/virt/hardware.py:1939:31: F821 undefined name 'Set'

while this is not an issue today because we pin to an old version of
flake8 we should still fix this just as a code hygiene issue. given this
has no impact on the running code im going to triage this as low an push
a trivial patch.

** Affects: nova
     Importance: Low
     Assignee: sean mooney (sean-k-mooney)
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1855934

Title:
  new versions of flake8 parse typeing coments

Status in OpenStack Compute (nova):
  New

Bug description:
  while playing with pre-commit i notice that new versions of flake8 parse type annotion comments.
  if you have not imported the relevent typing module then  it fails with F821 undefined name 

  nova/virt/hardware.py:1396:5: F821 undefined name 'Optional'
  nova/virt/hardware.py:1396:5: F821 undefined name 'List'
  nova/virt/hardware.py:1396:5: F821 undefined name 'Set'
  nova/virt/hardware.py:1426:5: F821 undefined name 'Optional'
  nova/virt/hardware.py:1426:5: F821 undefined name 'List'
  nova/virt/hardware.py:1426:5: F821 undefined name 'Set'
  nova/virt/hardware.py:1456:5: F821 undefined name 'Optional'
  nova/virt/hardware.py:1483:5: F821 undefined name 'Optional'
  nova/virt/hardware.py:1525:5: F821 undefined name 'Optional'
  nova/virt/hardware.py:1624:5: F821 undefined name 'Tuple'
  nova/virt/hardware.py:1646:5: F821 undefined name 'Optional'
  nova/virt/hardware.py:1658:5: F821 undefined name 'Optional'
  nova/virt/hardware.py:1674:5: F821 undefined name 'List'
  nova/virt/hardware.py:1696:5: F821 undefined name 'Optional'
  nova/virt/hardware.py:1920:29: F821 undefined name 'List'
  nova/virt/hardware.py:1939:31: F821 undefined name 'Set'

  while this is not an issue today because we pin to an old version of
  flake8 we should still fix this just as a code hygiene issue. given
  this has no impact on the running code im going to triage this as low
  an push a trivial patch.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1855934/+subscriptions