yahoo-eng-team team mailing list archive

[Matt Riedemann <mriedem.os@xxxxxxxxx>]

Hmm this should pull the status from the request and put it on the
response:

https://github.com/openstack/nova/blob/e6f742544432d6066f1fba4666580919eb7859bd/nova/api/openstack/compute/server_external_events.py#L96

and then changed to completed here because the instance.host is set so
we're going to process the event:

https://github.com/openstack/nova/blob/e6f742544432d6066f1fba4666580919eb7859bd/nova/api/openstack/compute/server_external_events.py#L133

I think this is working as designed.

** Changed in: nova
       Status: New => Opinion

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1856311

Title:
  server_external_events response status is always 'completed' instead
  of  event status which requested as failed

Status in OpenStack Compute (nova):
  Opinion

Bug description:
  Description
  ===========
  For the server external event rest api response is always completed instead of what the user requested to updated as failed/in-progress .

  here the changes required :
  https://github.com/openstack/nova/blob/aa096fd18352fb9da94069ec2cab478eed5c6cca/nova/api/openstack/compute/server_external_events.py#L133

  Steps to reproduce
  ==================
  1. POST a rest api request with the status as failed .
  2. API response event status will be always completed .

  Expected result
  ===============
  Post request :
  openstack/compute/v2.1/os-server-external-events
  {
   "events": [
     {
       "name": "network-vif-plugged",
       "tag": "foo",
       "server_uuid": "b20f436b-b9b6-4a8d-a1f7-411ed42ffe62",
       "status": "failed"
     }
    ]
  }

  Response :

  {
      "events": [
          {
              "status": "failed",
              "tag": "foo",
              "name": "network-vif-plugged",
              "server_uuid": "b20f436b-b9b6-4a8d-a1f7-411ed42ffe62",
              "code": 200
          }
      ]
  }

  
  Actual result
  =============

  Post request :
  openstack/compute/v2.1/os-server-external-events
  {
   "events": [
     {
       "name": "network-vif-plugged",
       "tag": "foo",
       "server_uuid": "b20f436b-b9b6-4a8d-a1f7-411ed42ffe62",
       "status": "failed"
     }
    ]
  }

  Response :

  {
      "events": [
          {
              "status": "completed",
              "tag": "foo",
              "name": "network-vif-plugged",
              "server_uuid": "b20f436b-b9b6-4a8d-a1f7-411ed42ffe62",
              "code": 200
          }
      ]
  }

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1856311/+subscriptions