yahoo-eng-team team mailing list archive

[OpenStack Infra <1838522@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/692074
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=161b4ae5d4a7a29f9e5c91d9b391dee49e075993
Submitter: Zuul
Branch:    master

commit 161b4ae5d4a7a29f9e5c91d9b391dee49e075993
Author: Marek <marek.lycka@xxxxxxxxxx>
Date:   Wed Oct 30 09:38:29 2019 +0100

    Fixes a series of bugs related to Floating IPs.
    
    - Fixes KeyErrors when accessing 'floatingip' values in usages, which
      broken Floating IP allocation.
    - The quota display in the bottom right of the Allocation dialog are
      only displayed if 'enabled_quotas' is True
    - Adds security group rule tallying for the usages overview page, which
      fixes a KeyError crash for installations where Horizon 'enable_quotas'
      is set to true, but the 'quota_details' extension is not installed on
      in Neutron
    - Adds a policy check to show and hide The plus/add button in
      Instances->Associate Floating IP to match the Allocate IP To Project
      button in Floating IPs
    - Fixed the page title not being set for the non-modal version of the
      modal allocation dialog/form
    - Added an 'allowed' functionality for network usage overview charts to
      allow for them to be dynamically disabled
    - Added tests and mocks for the above
    - Added tests for non-legacy quota tallying for networks
    - Added test for disabled network quotas in overview
    
    Change-Id: I47f73ff94664d315a2400feb8ce8a25f4e6beced
    closes-bug: #1838522


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1838522

Title:
  Disabled quotas break floating IPs

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  Setting  OPENSTACK_NEUTRON_NETWORK['enable_quotas'] breaks the
  floating ip allocation dialog in project/instances

  To reproduce:

  - Make sure OPENSTACK_NEUTRON_NETWORK['enable_quotas'] is set to false
  (settings.py, local_settings.py); this is currently the default
  setting in master.

  - Make sure an instance is running

  - Navigate to Project/Instances

  - Open the "Associate Floating IP" action for an instance

  - Click the + button next to the list of available floating ips

  - An IP allocation modal should come up

  Two  Issues manifest:

  - The quota display in the bottom right of the dialog is broken: it
  does not display numbers or the graphical representation of quotas

  - Attempting to allocate a new IP by clicking the 'Allocate IP' button
  fails with a (non-)exception in Horizon's log; it simply states
  'available'. This is caused by an unhandled keyerror
  /openstack_dashboard/dashboards/project/floating_ips/forms.py:59. With
  disabled quotas, the floatingip dictionary doesn't contain
  'available'.

  Reproduced on Stein devstack and Horizon master.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1838522/+subscriptions