yahoo-eng-team team mailing list archive

[OpenStack Infra <1857021@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/700011
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=3faba7cae0c5f0b8ac93c025ca057e2f533445cf
Submitter: Zuul
Branch:    master

commit 3faba7cae0c5f0b8ac93c025ca057e2f533445cf
Author: Slawek Kaplonski <skaplons@xxxxxxxxxx>
Date:   Thu Dec 19 16:12:09 2019 +0100

    [L3] Switch order of processing added and removed router ports
    
    It may happend that one router's port is going to be
    removed and another one (same IP but new subnet) is going to be added
    to the router in short time.
    That can lead to the problem that IP which is allocated to the new
    port is not added to keepalived's vips list because same IP address
    is already in this list (this exising IP address belongs to old port).
    But few seconds later old port is removed and finally router ends
    up with new port configured without IP address.
    
    To avoid such case, this patch switches order of processing new
    and deleted ports in _process_internal_ports() method in RouterInfo
    class.
    So now first old ports will be removed and than new ports will be
    configured so there will be no case when IP address is already added
    to VIPs list when it is going to be removed in few seconds.
    
    Change-Id: I72dc4a06a806731ec5124fa11c9f69c7dd6cbbb0
    Closes-Bug: #1857021


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1857021

Title:
  Wrong order of adding/deleting router ports may end up with not
  configured router port

Status in neutron:
  Fix Released

Bug description:
  In some cases when one subnet with some CIDR is removed from router
  and immediately removed and other subnet with same CIDR is created and
  added to the same router in very short time, it may happen that router
  port will not have IP address configured and subnet will be "isolated"
  so no traffic to/from other subnets connected to same router will be
  possible.

  It happens in L3 HA case because IP address from "old" port is still
  in Keepalived's vips list so it's skipped to be added to this list
  from new port.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1857021/+subscriptions