yahoo-eng-team team mailing list archive

[OpenStack Infra <1860209@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/703236
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=37521cee8d3058af835fb4dd9db94af1deff17b8
Submitter: Zuul
Branch:    master

commit 37521cee8d3058af835fb4dd9db94af1deff17b8
Author: Rodolfo Alonso Hernandez <ralonsoh@xxxxxxxxxx>
Date:   Sat Jan 18 12:32:36 2020 +0000

    Assign local variable before being referred
    
    Assign local variable "interface_name" before being referred in
    "TestL3Agent._router_fip_qos_after_admin_state_down_up"
    
    Change-Id: I5135f5c7c02b25728d2d8843889b9e8aef1265cd
    Closes-Bug: #1860209


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1860209

Title:
  Local variable referenced before assignment in
  "_router_fip_qos_after_admin_state_down_up"

Status in neutron:
  Fix Released

Bug description:
  In "TestL3Agent._router_fip_qos_after_admin_state_down_up", a local
  variable 'interface_name' can be referenced before assignment in some
  cases.


  Error log:
  ft1.1: neutron.tests.fullstack.test_l3_agent.TestHAL3Agent.test_router_fip_qos_after_admin_state_down_uptesttools.testresult.real._StringException: Traceback (most recent call last):
    File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/base.py", line 182, in func
      return f(self, *args, **kwargs)
    File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/fullstack/test_l3_agent.py", line 558, in test_router_fip_qos_after_admin_state_down_up
      self._router_fip_qos_after_admin_state_down_up(ha=True)
    File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/fullstack/test_l3_agent.py", line 246, in _router_fip_qos_after_admin_state_down_up
      interface_name,
  UnboundLocalError: local variable 'interface_name' referenced before assignment


  Link:
  https://7085ed736f9157d6d701-223d8b88d73ea59070ac36b627fdc3bc.ssl.cf1.rackcdn.com/700791/14/check
  /neutron-fullstack/ad85aba/testr_results.html

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1860209/+subscriptions