yahoo-eng-team team mailing list archive

[OpenStack Infra <1856839@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/701077
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=5f2758bb800c0376efd3e0526f808d73b9ad1bc0
Submitter: Zuul
Branch:    master

commit 5f2758bb800c0376efd3e0526f808d73b9ad1bc0
Author: LIU Yulong <i@xxxxxxxxxxxx>
Date:   Mon Sep 30 11:03:49 2019 +0800

    Move arp device check out of loop
    
    This could be time-consuming if there are lots of ports
    under the router. So this patch moves the same device
    check out of the loop.
    
    Closes-Bug: #1856839
    Change-Id: I2da856712aaafb77878628c52d19e0a5c7cdee0f


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1856839

Title:
  [L3] router processing time increase if there are large set ports

Status in neutron:
  Fix Released

Bug description:
  The function "_update_arp_entry" [1] was called under a double loop
  [2][3], and it has a "device.exists()" check [4]. When there are tons
  of ports under the router, the router processing time will definitely
  increase.

  [1] https://github.com/openstack/neutron/blob/master/neutron/agent/l3/dvr_local_router.py#L249
  [2] https://github.com/openstack/neutron/blob/master/neutron/agent/l3/dvr_local_router.py#L288-L290
  [3] https://github.com/openstack/neutron/blob/master/neutron/agent/l3/dvr_local_router.py#L291
  [4] https://github.com/openstack/neutron/blob/master/neutron/agent/l3/dvr_local_router.py#L260

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1856839/+subscriptions