yahoo-eng-team team mailing list archive

[Tom Stappaerts <1861442@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

When adding a qos policy to a network or port, there is the following check in the qos_plugin:
            # minimum-bandwidth rule is only supported (independently of
            # drivers) on networks whose first segment is backed by a physnet
            if rule.rule_type == qos_consts.RULE_TYPE_MINIMUM_BANDWIDTH:
                net = network_object.Network.get_object(
                    context, id=port.network_id)
                physnet = net.segments[0].physical_network
                if physnet is None:
                    raise qos_exc.QosRuleNotSupported(rule_type=rule.rule_type,
                                                      port_id=port['id'])
To my knowledge this statement is simply untrue as it is precisly the reference drivers which have this problem, not necessarily all drivers. This blocks me from creating a qos_driver that does support mimimum bandwidth without a physnet.
The same goes for min_bw_rule_updates when the port is bound.

I propose we move those checks to the qos_drivers themselves.

** Affects: neutron
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1861442

Title:
  QOS minimum bandwidth rejection of non-physnet network and updates
  should be driver specific

Status in neutron:
  New

Bug description:
  When adding a qos policy to a network or port, there is the following check in the qos_plugin:
              # minimum-bandwidth rule is only supported (independently of
              # drivers) on networks whose first segment is backed by a physnet
              if rule.rule_type == qos_consts.RULE_TYPE_MINIMUM_BANDWIDTH:
                  net = network_object.Network.get_object(
                      context, id=port.network_id)
                  physnet = net.segments[0].physical_network
                  if physnet is None:
                      raise qos_exc.QosRuleNotSupported(rule_type=rule.rule_type,
                                                        port_id=port['id'])
  To my knowledge this statement is simply untrue as it is precisly the reference drivers which have this problem, not necessarily all drivers. This blocks me from creating a qos_driver that does support mimimum bandwidth without a physnet.
  The same goes for min_bw_rule_updates when the port is bound.

  I propose we move those checks to the qos_drivers themselves.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1861442/+subscriptions