yahoo-eng-team team mailing list archive

[OpenStack Infra <1836295@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/670446
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=a95398d012ffdd82e7d4a5e591dfd88e68f44f24
Submitter: Zuul
Branch:    master

commit a95398d012ffdd82e7d4a5e591dfd88e68f44f24
Author: Stephen Crawley <s.crawley@xxxxxxxxx>
Date:   Thu Jul 11 10:17:24 2019 +1000

    Manually registering 2 Dashboards breaks get_dashboards() (python3)
    
    The get_dashboards() method used sorted(<values>) to sort the
    dashboards that have been registered manually.  This breaks if
    two or more are registered that way because the Dashboard class
    doesn't define a natural ordering.  The fix is to sort using
    the Dashboard name as the sort key.  (Unit test included.)
    
    This problem doesn't occur in python 2.7.
    
    P.S.
    It turns out that AdminPanel in horizon/test/unit/test_base.py is not
    used during the review. It is dropped too as it is a simple change.
    
    Change-Id: I6be10a92a1f43b3e0effee8148987c7e2c5690ff
    Closes-bug: #1836295


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1836295

Title:
  Registering 2 Dashboards breaks get_dashboards

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  When 2 or more Dashboards are registered manually, the
  get_dashboards() method breaks saying that '<' is not supported
  between the dashboard classes.  The problem is that the
  get_dashboards() method attempts to order the manually registered
  dashboards (alphabetically according to the docs) by Dashboard doesn't
  define a natural ordering.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1836295/+subscriptions