yahoo-eng-team team mailing list archive

[OpenStack Infra <1861876@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/705760
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=eef658bf5354e1a47b742851c29a1479c9aebcf8
Submitter: Zuul
Branch:    master

commit eef658bf5354e1a47b742851c29a1479c9aebcf8
Author: Stephen Finucane <sfinucan@xxxxxxxxxx>
Date:   Tue Feb 4 15:44:54 2020 +0000

    Handle neutron without the fip-port-details extension
    
    The 'fip-port-details' API extension was added to neutron in Rocky [1]
    and is optional. As a result, we cannot rely on the 'port_details' field
    being present in API responses. If it is not, we need to make a second
    query for all ports and build 'port_details' using the 'port_id' field.
    
    [1] https://docs.openstack.org/releasenotes/neutron-lib/rocky.html#relnotes-1-14-0-stable-rocky-new-features
    
    Change-Id: Ifb96f31f471cc0a25c1dfce2161a669b97a384ae
    Signed-off-by: Stephen Finucane <sfinucan@xxxxxxxxxx>
    Closes-bug: #1861876


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1861876

Title:
  [Neutron API] Neutron Floating IP not always have 'port_details'

Status in neutron:
  New
Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  1) Neutron Floating IP 'port_details' key is part of an extension.
  That means not always will be present in the Floating IP dictionary.
  Since [1], in [2] is assumed that this key is always present. That
  should be checked first.

  2) The same patch [1] also introduced an error when retrieving the
  network ID [3]. The network ID is stored in a key named
  "floating_network_id" [4].

  n-api log example: http://paste.openstack.org/show/789108/

  CI job failing (breaking Neutron CI!!!):
  https://0ebef4bf8afa09d1c4c9-5e4b426cf1ca8d9cb4613ee1042e28ab.ssl.cf5.rackcdn.com/704530/4/check
  /neutron-ovn-tempest-ovs-release/c0a29b4/testr_results.html

  [1]https://review.opendev.org/#/c/697153/
  [2]https://review.opendev.org/#/c/697153/16/nova/api/openstack/compute/floating_ips.py@40
  [3]https://review.opendev.org/#/c/697153/16/nova/api/openstack/compute/floating_ips.py@47
  [4]https://github.com/openstack/neutron/blob/master/neutron/db/l3_db.py#L1030-L1037

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1861876/+subscriptions