← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1861670] Re: AttributeError: 'NetworkConnectivityTest' object has no attribute 'safe_client'

 

Reviewed:  https://review.opendev.org/705413
Committed: https://git.openstack.org/cgit/openstack/neutron-tempest-plugin/commit/?id=2a71a8966492adb222e6fc289e77f7afc681d082
Submitter: Zuul
Branch:    master

commit 2a71a8966492adb222e6fc289e77f7afc681d082
Author: Slawek Kaplonski <skaplons@xxxxxxxxxx>
Date:   Mon Feb 3 11:48:34 2020 +0100

    Fix test_connectivity_dvr_and_no_dvr_routers_in_same_subnet test
    
    This patch fixes couple of issues in scenario test from
    test_connectivity module.
    
    1. Replace safe_client with client object
       In class NetworkConnectivityTest there was used safe_client
       but there is no such attribute in this class. Object "client"
       should be used instead.
    
    2. It also fixes in the same test how external network's subnet
       ID is get from the network's info.
    
    3. Change to use admin_client to get details of external
       network's subnet as this subnet don't belongs to tenant user
       so regular client gets 404 error while doing subnet_show
       command.
    
    4. Check the subnets IP version to retrieve only an IPv4 one.
    
    Change-Id: Ibebb20b29dd6ae902d194fd26ba1ea728a976286
    Closes-bug: #1861670


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1861670

Title:
  AttributeError: 'NetworkConnectivityTest' object has no attribute
  'safe_client'

Status in neutron:
  Fix Released

Bug description:
  Since few days test
  neutron_tempest_plugin.scenario.test_connectivity.NetworkConnectivityTest.test_connectivity_dvr_and_no_dvr_routers_in_same_subnet
  is failing with error like:

  ft1.1: neutron_tempest_plugin.scenario.test_connectivity.NetworkConnectivityTest.test_connectivity_dvr_and_no_dvr_routers_in_same_subnet[id-69d3650a-5c32-40bc-ae56-5c4c849ddd37]testtools.testresult.real._StringException: Traceback (most recent call last):
    File "/opt/stack/tempest/tempest/common/utils/__init__.py", line 108, in wrapper
      return func(*func_args, **func_kwargs)
    File "/opt/stack/tempest/.tox/tempest/lib/python3.6/site-packages/neutron_tempest_plugin/scenario/test_connectivity.py", line 188, in test_connectivity_dvr_and_no_dvr_routers_in_same_subnet
      ext_network = self.safe_client.show_network(self.external_network_id)
  AttributeError: 'NetworkConnectivityTest' object has no attribute 'safe_client'

  Logstash query:
  http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22AttributeError%3A%20'NetworkConnectivityTest'%20object%20has%20no%20attribute%20'safe_client'%5C%22

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1861670/+subscriptions


References