yahoo-eng-team team mailing list archive

[OpenStack Infra <1861680@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/705452
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=d8349033e9ac925402a46cfd85cba113a3ca896f
Submitter: Zuul
Branch:    master

commit d8349033e9ac925402a46cfd85cba113a3ca896f
Author: Rodolfo Alonso Hernandez <ralonsoh@xxxxxxxxxx>
Date:   Mon Feb 3 14:06:31 2020 +0000

    Enforce "qos_max_rate" and "qos_burst" in OVN QoS options
    
    If QoS rule is QosBandwidthLimitRule, then the generated options in
    the QoS OVN driver of the QoS service should contain those two
    parameters: "qos_max_rate" and "qos_burst".
    
    According to [1], the units used are:
    - qos_max_rate: kbps, the one used in Neutron
    - qos_burst: kilobits, the one used in Neutron
    
    A "rule.max_kbps" value should be always present in the rule, but not
    "rule.max_burst_kbps". This value can be None in
    OvnNbApiIdlImpl.QoSAddCommand.
    
    [1]http://www.openvswitch.org/support/dist-docs/ovn-nbctl.8.html
    
    Change-Id: Ie1598be7d21f33df6b1a66fa71ba6783d2433dca
    Closes-Bug: #1861680


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1861680

Title:
  [OVN] QoS OVN driver does not return a correct set of qos options

Status in neutron:
  Fix Released

Bug description:
  OVNQosDriver._generate_port_options does not generate a correct set of QoS options, needed by the OVN driver:
  - max_kbps and max_burst_kbps units should be handled properly [1]
  - both parameters "qos_max_rate" and "qos_burst" must be present in the "options" dictionary, needed in [2] 

  
  [1]http://www.openvswitch.org/support/dist-docs/ovn-nbctl.8.html
  [2]https://github.com/openstack/neutron/blob/e17464ad11bec9555ee1ac51159b7e15711050c5/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py#L717-L718

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1861680/+subscriptions