yahoo-eng-team team mailing list archive

[OpenStack Infra <1864186@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/709100
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=caa34c279756164357bbcb9900aee36d0501d73f
Submitter: Zuul
Branch:    master

commit caa34c279756164357bbcb9900aee36d0501d73f
Author: Lucian Petrut <lpetrut@xxxxxxxxxxxxxxxxxxxxxx>
Date:   Fri Feb 21 13:21:20 2020 +0200

    Drop invalid rootwrap filters
    
    A recent change introduced a couple of rootwrap filters that are
    supposed to allow running ping within a network namespace.
    
    Those filters will actually replace the "ip" command with "ping",
    which leads to an invalid command.
    
    Since those two filters are now superfluous, we're going to drop
    them.
    
    Change-Id: I57869c68e858503ed8d6b86506c79c289f2820e1
    Closes-Bug: #1864186


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1864186

Title:
  "ping" prepended to ip netns commands

Status in neutron:
  Fix Released

Bug description:
  A recent patch[1] updated rootwrap filters so that ping may be used within a network namespace. The issue is that now all ip netns commands get altered, the "ip" command being replaced with "ping":
  http://paste.openstack.org/raw/789845/

  In particular, this seems to affect the IpNetnsExecFilter filter.

  This seems to be caused by the fact that the executable from the
  original command gets replaced with the one from the filter [2].

  [1] Ie5cbc0dcc76672b26cd2605f08cfd17a30b4c905
  [2] https://github.com/openstack/oslo.rootwrap/blob/6.0.0/oslo_rootwrap/filters.py#L71-L75

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1864186/+subscriptions