yahoo-eng-team team mailing list archive

[OpenStack Infra <1818345@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/690383
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=6ee0da7e5bffcfa70bfae60d60345c42fbc881b9
Submitter: Zuul
Branch:    master

commit 6ee0da7e5bffcfa70bfae60d60345c42fbc881b9
Author: Matt Riedemann <mriedem.os@xxxxxxxxx>
Date:   Tue Oct 22 15:22:28 2019 -0400

    api-ref: mark device response param as optional for list/show vol attachments
    
    The 'device' response parameter is not included in
    GET /servers/{server_id}/os-volume_attachments or
    GET /servers/{server_id}/os-volume_attachments/{volume_id}
    when the BDM doesn't have a device_name set, which can be the
    case with a volume attached to a shelved offloaded server.
    Also, see the logic in _translate_attachment_detail_view
    and _translate_attachment_summary_view. This simply marks
    the response parameter as optional in those APIs. Since
    the parameter is optional, it is sorted to after the required
    parameters but before the parameters added in new microversions.
    
    Change-Id: Ifda2f7983f349d51d97e5621cac6c5ad9cb0295f
    Closes-Bug: #1818345


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1818345

Title:
  api-ref: list/show volume attachment response parameter "device"
  should be marked optional

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  The "device" parameter for the following API responses is not marked
  optional in the API reference but should be due to this conditional:

  https://github.com/openstack/nova/blob/ffd73deffbc54222b04aa4c80ad236c01bdd716d/nova/api/openstack/compute/volumes.py#L239

  - GET /servers/{server_id}/os-volume_attachments (list)
  - GET /servers/{server_id}/os-volume_attachments/{volume_id} (show)

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1818345/+subscriptions