← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1864630] Re: Hard Reboot VM with multiple port lost QoS

 

Reviewed:  https://review.opendev.org/709687
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=5600163e9b4fb89b1525e9e415b1fedbe9526501
Submitter: Zuul
Branch:    master

commit 5600163e9b4fb89b1525e9e415b1fedbe9526501
Author: Nguyen Thanh Cong <ntcong1705@xxxxxxxxx>
Date:   Tue Feb 25 17:25:36 2020 +0700

    [OvS] Handle re_added multi ports
    
    Multiple ports are located in ports_re_added. Assume we have port_one
    and port_two. It will loop through the ports. Port_one is iterated
    first, events ['re_added'] is assigned port_one, events ['removed']
    is assigned port_two. In the second loop, events ['re_added'] is set
    to port_two instead of adding port_two to list. So after the loop,
    only port_two is left in events ['re_added'].
    
    Change-Id: If8edd29dd741f1688ffcac341fd58173539ba000
    Closes-Bug: #1864630


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1864630

Title:
  Hard Reboot VM with multiple port lost QoS

Status in neutron:
  Fix Released

Bug description:
  I have a VM with multiple ports, assume port_one and port_two. Both
  port have QoS. When i hard reboot my VM, port_two still has QoS,
  port_one loses.

  https://review.opendev.org/#/c/690098/11
  https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py#L1630
  It because both ports are located in ports_re_added. It will loop through the ports. port_one is iterated first, events ['re_added'] is assigned port_one, events ['removed'] is assigned port_two. In the second loop, events ['re_added'] is set to port_two instead of adding port_two to list. So after the loop, only port_two is left in events ['re_added'].

  Reproduce:
  - Create VM with multi port
  - Hard Reboot Server
  - Check QoS with command ovs-vsctl list interface <port>

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1864630/+subscriptions


References