← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1855708] Re: Reload tests broken in Py3

 

Reviewed:  https://review.opendev.org/713076
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=30ece7aa28ce8bef1bfe6d4ac68485e6b980f955
Submitter: Zuul
Branch:    master

commit 30ece7aa28ce8bef1bfe6d4ac68485e6b980f955
Author: Khuong Luu <lcamkhuong@xxxxxxxxx>
Date:   Fri Mar 13 14:54:54 2020 -0700

    Remove usages of SSL related config options in utils
    
    SSL support was removed by [1] which resulted in removal of some
    SSL related config options, but two config options 'key_file' and
    'cert_file' are still used in utils.stash_conf_values() which is called
    in reload functionality. When SIGHUP is sent to the parent process,
    this usage causes it to crash and its children processes become orphaned,
    which then causes the reload test to be stale (fail).
    
    This change also includes:
    - Remove 2 attributes and the decorator that help to skip this test
      (self.diable, self.disabled_message, and @skip_if_disabled)
    
    [1] https://review.opendev.org/#/c/697969/5/glance/common/wsgi.py
    
    Change-Id: I361c9d0b53a67b1cc60f0f3012e22accdcc46055
    Closes-Bug: #1855708


** Changed in: glance
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1855708

Title:
  Reload tests broken in Py3

Status in Glance:
  Fix Released
Status in Glance train series:
  New

Bug description:
  Looks like our reload is also broken in PY3 that has gone unnoticed as
  the test breakage was blamed on ssl.

  Test fails on timeout at worker change.

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1855708/+subscriptions


References