yahoo-eng-team team mailing list archive

[OpenStack Infra <1845628@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/685678
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=9ae4d9274e3e310fdd04c81e92e9c4803c434fff
Submitter: Zuul
Branch:    master

commit 9ae4d9274e3e310fdd04c81e92e9c4803c434fff
Author: Dongcan Ye <hellochosen@xxxxxxxxx>
Date:   Mon Sep 30 10:36:01 2019 +0000

    libvirt: Check the guest support UEFI
    
    commit 539d381434ccadcdc3f5d58c2705c35558a3a065 add a
    NVRAM flag in guest delete_configuration, but check
    UEFI support only in host side. If an instance does
    not boot from UEFI, but the host enable UEFI software
    like OVMF, the NVRAM flag always delete.
    
    This patch also check the guest support UEFI.
    
    Change-Id: I3448b89f58f3c3a85d15ee5a870c24b4b7f201df
    Closes-Bug: #1845628


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1845628

Title:
  Check UEFI support not insufficient

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  Now, delete instance, swap volume and snapshot, we always clear NVRAM flags.
  This is not right, currently we only check the host support uefi booting for guests from "_has_uefi_support".
  If an instance not boot with UEFI but the host enable UEFI, we also needs to clear NVRAM flags in guest delete_configuration.

  IMO, we need to check the instance(guest) and host support UEFI both,
  like check the instance's image_meta.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1845628/+subscriptions