yahoo-eng-team team mailing list archive

[OpenStack Infra <1868121@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/713905
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=d10ed8e75b8861f13c4a3a3e823b7e679b08d0ef
Submitter: Zuul
Branch:    master

commit d10ed8e75b8861f13c4a3a3e823b7e679b08d0ef
Author: Kevin Zhao <kevin.zhao@xxxxxxxxxx>
Date:   Thu Mar 19 23:30:41 2020 +0800

    libvirt: Fix unit test error block info on non x86 architecture
    
    The Q35 machine type does not provide an IDE bus. As a result, when
    trying to provide a default bus for 'cdrom' type devices, we check the
    machine type and select either 'ide' or 'sata' depending on whether
    we're using the Q35 machine type. However, this only applies for x86 as
    other architectures use different machine types.
    
    The 'test_get_disk_bus_for_device_type_cdrom_with_q35_image_meta' test
    is intended to ensure that the retrieved bus type for a 'cdrom' type
    device is actually 'sata' when the machine type is 'q35'. However,
    this test can still fail on non-x86 platforms. Correct this by using
    the 'hw_architecture' image metadata property to ensure consistent
    behavior on all platforms.
    
    Change-Id: If9e173c8df2a7ab47dc5fca90e1d333c0f34197b
    Signed-off-by: Kevin Zhao <kevin.zhao@xxxxxxxxxx>
    Closes-Bug: #1868121


** Changed in: nova
       Status: Confirmed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1868121

Title:
  block info get cdrom error on non x86 platform

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  nova.tests.unit.virt.libvirt.test_blockinfo.LibvirtBlockInfoTest.test_get_disk_bus_for_device_type_cdrom_with_q35_image_meta
  ----------------------------------------------------------------------------------------------------------------------------

  Captured traceback:
  ~~~~~~~~~~~~~~~~~~~
      Traceback (most recent call last):
        File "/opt/stack/nova/nova/tests/unit/virt/libvirt/test_blockinfo.py", line 839, in test_get_disk_bus_for_device_type_cdrom_with_q35_image_meta
          self.assertEqual('sata', bus)
        File "/opt/stack/nova/.tox/py36/lib/python3.6/site-packages/testtools/testcase.py", line 411, in assertEqual
          self.assertThat(observed, matcher, message)
        File "/opt/stack/nova/.tox/py36/lib/python3.6/site-packages/testtools/testcase.py", line 498, in assertThat
          raise mismatch_error
      testtools.matchers._impl.MismatchError: 'sata' != 'scsi'

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1868121/+subscriptions