← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1700428] Re: trunk parent port/subport need limitation

 

Reviewed:  https://review.opendev.org/477286
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=8ebc635a18fd23fd6595551a703961a4d4392948
Submitter: Zuul
Branch:    master

commit 8ebc635a18fd23fd6595551a703961a4d4392948
Author: ZhaoBo <zhaobo6@xxxxxxxxxx>
Date:   Mon Jul 31 19:23:32 2017 +0800

    Subcribe trunk & subport events to set subport id
    
    Introduce a callback function in trunk plugin to receive after_create
    and after_delete events for the trunk and subport resources This
    function will set the subport device_id to trunk_id to prevent nova and
    neutron from reusing it.
    
    Closes-Bug: #1700428
    Co-Authored-By: Nate Johnston <nate.johnston@xxxxxxxxxx>
    Change-Id: I97fe59752f9ef2cbe0376cd6ee0739660f5937ad


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1700428

Title:
  trunk parent port/subport need limitation

Status in neutron:
  Fix Released

Bug description:
  Currently, we use the trunk parent port to boot instance. But no limit
  to use trunk parent port to add router interface or use subports to
  boot some instances.

  And the trunk service only subscribe port delete, we need subscribe
  the port update to not allow user to use parent port to other way, and
  subport check to let user know the port is used by a trunk.

  
  repro
  =======
  Thanks for return. As the test env had been destroyed. I maybe miss some thing.
  The repro steps are:
  parent port case:
  1. create 2 networks, named net1 and net2.Create subnet1 and subnet2.
  2. create "parent" port from net1 and "subport" port from net2.
  3. Then create trunk resource "trunk" with "parent" as parent port and "subport" as subport.
  4. create a router Router. And set "parent" as subnet1 interface to Router.
  5. can not remove "parent" port from Router, server raise the "parent" had been associated with a trunk "trunk".
  6. can not delete "trunk", and no api to update the parent port.

  subport case:
  1-3. The same with the 1 to 3 steps.
  4.Use subport to launch an instance A, then the subport device_owner will be updated with "compute:nova". 
  5.Now use parent port to launch an instance B
  6.delete instance A. subport's device_onwer not correct and status is DOWN.

  So I think we may limit this kind use cases. Not allow users to use
  parent port/subport like this.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1700428/+subscriptions


References