← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1870385] Re: AcceleratorServerTest.test_create_server_with_error fails intermittently

 

Reviewed:  https://review.opendev.org/717070
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=a85e6e07cfa34725922d5d31dbe6956797e9b3f2
Submitter: Zuul
Branch:    master

commit a85e6e07cfa34725922d5d31dbe6956797e9b3f2
Author: Balazs Gibizer <balazs.gibizer@xxxxxxxx>
Date:   Thu Apr 2 17:47:20 2020 +0200

    Stabilize functional tests
    
    If a driver.spawn fails without triggering a re-schedule then the
    placement cleanup and the compute build failure counter update
    happens after every externally observable change (instance
    state change, instance fault recording, notification sending) in
    the finally block of _locked_do_build_and_run_instance() call.
    
    We have couple of functional tests that assert either the placement
    cleanup or the state of the build counter. These tests are unstable as
    the test races with the compute manager code. As there are no externally
    visible change to wait for this patch introduces some retry to
    these tests to stabilize them.
    
    Closes-Bug: #1870385
    
    Change-Id: I68369e7fa7630a212f4b20fc09f4c40796934bb9


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1870385

Title:
  AcceleratorServerTest.test_create_server_with_error fails
  intermittently

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  The AcceleratorServerTest.test_create_server_with_error functional
  test is unstable on the gate.

  Traceback (most recent call last):
    File "/home/zuul/src/opendev.org/openstack/nova/nova/tests/functional/test_servers.py", line 8004, in test_create_server_with_error
      self._check_no_allocs_usage(server_uuid)
    File "/home/zuul/src/opendev.org/openstack/nova/nova/tests/functional/test_servers.py", line 7943, in _check_no_allocs_usage
      self.assertEqual(allocs, {})
    File "/home/zuul/src/opendev.org/openstack/nova/.tox/functional-py36/lib/python3.6/site-packages/testtools/testcase.py", line 415, in assertEqual
      self.assertThat(observed, matcher, message)
    File "/home/zuul/src/opendev.org/openstack/nova/.tox/functional-py36/lib/python3.6/site-packages/testtools/testcase.py", line 502, in assertThat
      raise mismatch_error
  testtools.matchers._impl.MismatchError: !=:
  reference = {'20feee24-6050-496b-8ad8-906dd2cc30fc': {'generation': 3,
                                            'resources': {'DISK_GB': 20,
                                                          'MEMORY_MB': 2048,
                                                          'VCPU': 2}},
   '678fe533-5851-4766-89a9-e1bb6fcfadd9': {'generation': 3,
                                            'resources': {'FPGA': 1}}}
  actual    = {}

  
  https://0b0e867dded4f80d6512-217ff60ed5d3b708136ee1404afca04a.ssl.cf5.rackcdn.com/716141/2/check/nova-tox-functional-py36/88a8970/testr_results.html

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1870385/+subscriptions


References