yahoo-eng-team team mailing list archive

[OpenStack Infra <1870484@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/717189
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=e097dbdbb8c1d236e3ca7930a6aa8bc42a54731b
Submitter: Zuul
Branch:    master

commit e097dbdbb8c1d236e3ca7930a6aa8bc42a54731b
Author: Ghanshyam Mann <gmann@xxxxxxxxxxxxxxxxx>
Date:   Fri Apr 3 01:48:57 2020 -0500

    Fix server metadata policy to be admin_or_owner
    
    unlock server API policy is default to admin_or_owner[1] but API
    is allowed for everyone.
    
    We can see the test trying with other project context can access the API
    - https://review.opendev.org/#/c/717182/
    
    This is because API does not pass the server project_id in policy target[2]
    and if no target is passed then, policy.py add the default targets which is
    nothing but context.project_id (allow for everyone who try to access)[3]
    
    This commit fix this policy by passing the server's project_id in policy
    target.
    
    Closes-bug: #1870484
    Partial implement blueprint policy-defaults-refresh
    
    [1] https://github.com/openstack/nova/blob/e487b05f7e451af4f29699c3b34d9d2cc1b1205a/nova/policies/server_metadata.py#L27
    [2] https://github.com/openstack/nova/blob/e487b05f7e451af4f29699c3b34d9d2cc1b1205a/nova/api/openstack/compute/server_metadata.py#L123
    [3] https://github.com/openstack/nova/blob/c16315165ce307c605cf4b608b2df3aa06f46982/nova/policy.py#L191
    
    Change-Id: Ia327ebeb6ccf434d12df6a61fbd9ab9f5cf6d04f


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1870484

Title:
  server metadata API policy is allowed for everyone even policy
  defaults is admin_or_owner

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  server metadata API policy is default to admin_or_owner[1] but API is
  allowed for everyone.

  We can see the test trying with other project context can access the API
  - https://review.opendev.org/#/c/717182/

  This is because API does not pass the server project_id in policy target
  - https://github.com/openstack/nova/blob/e487b05f7e451af4f29699c3b34d9d2cc1b1205a/nova/api/openstack/compute/server_metadata.py#L123

  and if no target is passed then, policy.py add the default targets which is nothing but context.project_id (allow for everyone try to access)
  - https://github.com/openstack/nova/blob/c16315165ce307c605cf4b608b2df3aa06f46982/nova/policy.py#L191

  [1]
  - https://github.com/openstack/nova/blob/e487b05f7e451af4f29699c3b34d9d2cc1b1205a/nova/policies/server_metadata.py#L27

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1870484/+subscriptions