← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1872940] [NEW] vpnaas pluto.pid file path wrong

 

Public bug reported:

currently, class OpenSwanProcess weil define

self.pid_file = '%s.pid' % self.pid_path

print pid_file in log file:
e.g:
/opt/stack/data/neutron/ipsec/4d97aa64-10c1-42ab-9d49-0aeb682e3d8f/var/run/pluto.pid

but the cmd to start pluto process

sudo neutron-rootwrap /etc/neutron/rootwrap.conf ip netns exec snat-
4d97aa64-10c1-42ab-9d49-0aeb682e3d8f neutron-vpn-netns-wrapper
--mount_paths=/etc:/var/lib/neutron/ipsec/4d97aa64-10c1-42ab-
9d49-0aeb682e3d8f/etc,/var/run:/var/lib/neutron/ipsec/4d97aa64-10c1
-42ab-9d49-0aeb682e3d8f/var/run
--rootwrap_config=/etc/neutron/rootwrap.conf --cmd=ipsec,pluto,--use-
netkey,--uniqueids,--perpeerlog,--
perpeerlogbase,/var/lib/neutron/ipsec/4d97aa64-10c1-42ab-
9d49-0aeb682e3d8f/log

will generate pid file: 
/opt/stack/data/neutron/ipsec/4d97aa64-10c1-42ab-9d49-0aeb682e3d8f/var/run/pluto/pluto.pid

means self.pid_file defined in class OpenSwanProcess is wrong.


and in the function def _cleanup_control_files(self), determination of file exist or not will always get False, pid file will not be cleaned. and ctl_file defined in this function is also wrong.


if the pluto.pid not been deleted, when we start  neutron-l3-agent, we will get an error, pluto.pid exists, and the pluto process will fail to start.

** Affects: neutron
     Importance: Undecided
         Status: New


** Tags: vpnaas

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1872940

Title:
  vpnaas pluto.pid file path wrong

Status in neutron:
  New

Bug description:
  currently, class OpenSwanProcess weil define

  self.pid_file = '%s.pid' % self.pid_path

  print pid_file in log file:
  e.g:
  /opt/stack/data/neutron/ipsec/4d97aa64-10c1-42ab-9d49-0aeb682e3d8f/var/run/pluto.pid

  but the cmd to start pluto process

  sudo neutron-rootwrap /etc/neutron/rootwrap.conf ip netns exec snat-
  4d97aa64-10c1-42ab-9d49-0aeb682e3d8f neutron-vpn-netns-wrapper
  --mount_paths=/etc:/var/lib/neutron/ipsec/4d97aa64-10c1-42ab-
  9d49-0aeb682e3d8f/etc,/var/run:/var/lib/neutron/ipsec/4d97aa64-10c1
  -42ab-9d49-0aeb682e3d8f/var/run
  --rootwrap_config=/etc/neutron/rootwrap.conf --cmd=ipsec,pluto,--use-
  netkey,--uniqueids,--perpeerlog,--
  perpeerlogbase,/var/lib/neutron/ipsec/4d97aa64-10c1-42ab-
  9d49-0aeb682e3d8f/log

  will generate pid file: 
  /opt/stack/data/neutron/ipsec/4d97aa64-10c1-42ab-9d49-0aeb682e3d8f/var/run/pluto/pluto.pid

  means self.pid_file defined in class OpenSwanProcess is wrong.

  
  and in the function def _cleanup_control_files(self), determination of file exist or not will always get False, pid file will not be cleaned. and ctl_file defined in this function is also wrong.

  
  if the pluto.pid not been deleted, when we start  neutron-l3-agent, we will get an error, pluto.pid exists, and the pluto process will fail to start.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1872940/+subscriptions