← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1873708] Re: Floating IP was not removed from the router when the port forwarding deletion was completed

 

Reviewed:  https://review.opendev.org/721129
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=3a6a8c334a65acd658072c2f681b35dac9ca3fcd
Submitter: Zuul
Branch:    master

commit 3a6a8c334a65acd658072c2f681b35dac9ca3fcd
Author: zhouhenglc <zhouhenglc@xxxxxxxxxx>
Date:   Mon Apr 20 08:34:25 2020 +0800

    Provide correct fip cidr when deleting port forwarding
    
    The second parameter of fip_id_cidrs requires a cidr, but now is address. this
    causes function `_sync_and_remove_fip` fail to remove vip as expected.
    
    if current is ha router, in function _sync_and_remove_fip will call
    `ri._remove_vip(fip_id_cidr[1])`. the final parameter is passed to
    KeepalivedInstance.remove_vip_by_ip_address and compare with attribute vips.
    the values of vips are of type CIDR.
    
    if not ha, the following process processing use netaddr.IPNetwork and can be
    performed as expected.
    
    Closes-bug: #1873708
    
    Change-Id: I2ae2ade29700a56dc340256389bf8b0efd697ba4


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1873708

Title:
  Floating IP was not removed from the router when the port forwarding
  deletion was completed

Status in neutron:
  Fix Released

Bug description:
  1. Create a floating IP A
  2. Create port forwarding on floating IP A
  3. Delete port forwarding
  4. Add the same port forwarding again

  After step 3, It can be found that floating IP is still in the router network namespace.
  After step 4, the floating IP's status still DOWN

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1873708/+subscriptions


References