yahoo-eng-team team mailing list archive

[OpenStack Infra <1878708@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/728306
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=ccb0cddd4af6ceb4ed4e8a2612d6c705d16a8e64
Submitter: Zuul
Branch:    master

commit ccb0cddd4af6ceb4ed4e8a2612d6c705d16a8e64
Author: Terry Wilson <twilson@xxxxxxxxxx>
Date:   Thu May 14 22:27:10 2020 +0000

    Fix mock.patch.stopall issue with ovsdbapp
    
    After I876919dfc1fa0ae36bd99e3d760e38d207ee6ef3, two test classes
    that inherit from both neutron's oslotest-based base classes and
    ovsdbapp's unittest-based base class would fail due to
    mock.patch.stopall being called twice. This appears to be because
    of some special handling in oslotest addCleanup that checks a
    private _cleanups variable before adding a cleanup to stopall.
    Changing the order of the imports so that neutron can register its
    cleanups first seems to fix the issue.
    
    Closes-Bug: #1878708
    Change-Id: I5b3812a9765a37b3e66d6c8ca0cb42ee1b7a2b9a


** Changed in: neutron
       Status: Incomplete => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1878708

Title:
  mock.patch.stopall called twice on tests inheriting from ovsdbapp

Status in neutron:
  Fix Released

Bug description:
  After I876919dfc1fa0ae36bd99e3d760e38d207ee6ef3, two test classes that
  inherit from both neutron's oslotest-based base classes and ovsdbapp's
  unittest-based base class would fail due to mock.patch.stopall being
  called twice. This appears to be because of some special handling in
  oslotest addCleanup that checks a private _cleanups variable before
  adding a cleanup to stopall. Changing the order of the imports so that
  neutron can register its cleanups first seems to fix the issue.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1878708/+subscriptions