yahoo-eng-team team mailing list archive

[Neil Jerram <neil@xxxxxxxxx>]

Public bug reported:

This merge -
https://opendev.org/openstack/neutron/commit/a6fb2faaa5d46656db9085ad6bcfc65ded807871
- to the Neutron stable/rocky branch on April 23rd, has broken my team's
Neutron plugin, by requiring 3rd party LinuxInterfaceDriver subclasses
to take a new 'link_up' argument in their 'plug_new' method.

Here's the fix that I've now made: https://github.com/projectcalico
/networking-
calico/pull/21/commits/bfd54aa841abbba4c591126b0dba083b93c84536

However, this likely affects other out-of-tree plugins as well, and
there is still the likelihood of breakage if someone is running Rocky
with an affected-but-unfixed plugin, and uses the latest Rocky code.

Apparently there will not be another Rocky patch release, so I wonder if
it would be better to revert the incompatible change?

** Affects: neutron
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1879307

Title:
  Recent stable/rocky change breaks networking-calico's interface driver

Status in neutron:
  New

Bug description:
  This merge -
  https://opendev.org/openstack/neutron/commit/a6fb2faaa5d46656db9085ad6bcfc65ded807871
  - to the Neutron stable/rocky branch on April 23rd, has broken my
  team's Neutron plugin, by requiring 3rd party LinuxInterfaceDriver
  subclasses to take a new 'link_up' argument in their 'plug_new'
  method.

  Here's the fix that I've now made: https://github.com/projectcalico
  /networking-
  calico/pull/21/commits/bfd54aa841abbba4c591126b0dba083b93c84536

  However, this likely affects other out-of-tree plugins as well, and
  there is still the likelihood of breakage if someone is running Rocky
  with an affected-but-unfixed plugin, and uses the latest Rocky code.

  Apparently there will not be another Rocky patch release, so I wonder
  if it would be better to revert the incompatible change?

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1879307/+subscriptions