yahoo-eng-team team mailing list archive

[OpenStack Infra <1804811@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/619723
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=cf74d2403272d37e011911b4bd9ffb5f1d8f3b9b
Submitter: Zuul
Branch:    master

commit cf74d2403272d37e011911b4bd9ffb5f1d8f3b9b
Author: Matthew Booth <mbooth@xxxxxxxxxx>
Date:   Fri Nov 23 11:51:25 2018 +0000

    Fix configure() called after DatabaseAtVersion fixture
    
    DatabaseAtVersion causes the transaction context manager of its
    database to be started, but doesn't set SESSION_CONFIGURED as used by
    the Database fixture. Consequently, a subsequent test using the
    Database fixture will attempt to call configure on a started context
    manager, and fail.
    
    We fix this by rolling the functionality of DatabaseAtVersion into
    Database.
    
    Change-Id: Ia6b63e0d26df53e611a5a36e5a2eeb09a73e4704
    Closes-bug: #1804811


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1804811

Title:
  DatabaseAtVersion fixture causes order-related failures in tests using
  Database fixture

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  The DatabaseAtVersion fixture starts the global TransactionContext,
  but doesn't set the guard to configure() used by the Database fixture.
  Consequently, if Database runs after DatabaseAtVersion in the same
  worker, the subsequent fixture will fail. An example ordering which
  fails is:

  nova.tests.unit.db.test_sqlalchemy_migration.TestNewtonCellsCheck.test_upgrade_without_cell0
  nova.tests.unit.db.test_sqlalchemy_migration.TestNewtonCheck.test_pci_device_type_vf_not_migrated

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1804811/+subscriptions