yahoo-eng-team team mailing list archive

[OpenStack Infra <1841932@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/722187
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=bf488a8630702160021b5848bf6e86fbb8015205
Submitter: Zuul
Branch:    master

commit bf488a8630702160021b5848bf6e86fbb8015205
Author: ramboman <lijie@xxxxxxxxxxxxxxx>
Date:   Wed Apr 22 21:33:22 2020 +0800

    replace the "hide_hypervisor_id" to "hw:hide_hypervisor_id"
    
    When we use the flavor extra_specs "hide_hypervisor_id" in
    AggregateInstanceExtraSpecsFilter, then will retrun False.
    So we need correct the extra_specs.
    
    Change-Id: I9d8d8c3a30cf6da7e8fb48374347e069ab075df2
    Closes-Bug: 1841932


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1841932

Title:
  hide_hypervisor_id extra_specs in nova flavor cannot pass
  AggregateInstanceExtraSpecsFilter

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  Description
  ===========
  when we enable nova AggregateInstanceExtraSpecsFilter, and then we need to passthrough a nvidia gpu so that we need to set hide_hypervisor_id in nova flavor extra specs. hide_hypervisor_id cannot pass the AggregateInstanceExtraSpecsFilter because of # Either not scope format, or aggregate_instance_extra_specs scope. 

  See the codes below:
              # Either not scope format, or aggregate_instance_extra_specs scope
              scope = key.split(':', 1)
              if len(scope) > 1:
                  if scope[0] != _SCOPE:
                      continue
                  else:
                      del scope[0]
              key = scope[0]

  
  Steps to reproduce
  ==================
  in nova.conf
  [filter_scheduler]
  enabled_filters = ....,AggregateInstanceExtraSpecsFilter,...

  create a flavor like "g3.8xlarge" and setting extra_specs
  "hide_hypervisor_id":

  nova flavor-key g3.8xlarge set hide_hypervisor_id=true

  then create a instance with flavor g3.8xlarge, it will report "Filter
  AggregateInstanceExtraSpecsFilter returned 0 hosts" in nova schedualer
  log.

  Environment
  ===========
  (nova-scheduler)[nova@control1 /]$ rpm -qa | grep nova
  openstack-nova-common-18.2.1-0.1.el7.noarch
  openstack-nova-scheduler-18.2.1-0.1.el7.noarch
  python-nova-18.2.1-0.1.el7.noarch
  python2-novaclient-11.0.0-1.el7.noarch

  
  I think this is a BUG in AggregateInstanceExtraSpecsFilter, can I suggest to remove the "not scope format" support in AggregateInstanceExtraSpecsFilter? or add a explicitly scope for "hide_hypervisor_id". Otherwise, I cannot use AggregateInstanceExtraSpecsFilter and hide_hypervisor_id at the same time.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1841932/+subscriptions