← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1882588] Re: DHCP client/server ports incorrectly defined in constants file

 

Reviewed:  https://review.opendev.org/734181
Committed: https://git.openstack.org/cgit/openstack/neutron-lib/commit/?id=d7900610163705a624493a9924c72abfbc338b49
Submitter: Zuul
Branch:    master

commit d7900610163705a624493a9924c72abfbc338b49
Author: Brian Haley <bhaley@xxxxxxxxxx>
Date:   Mon Jun 8 15:27:20 2020 -0400

    Correctly define DHCP port numbers for IPv4
    
    The client and server DHCP port numbers are opposite
    of what they should be according to the IANA definitions.
    
    Change-Id: Iaa74ec5d569a3dee65f7e788394ffe063748bab6
    Closes-bug: #1882588


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1882588

Title:
  DHCP client/server ports incorrectly defined in constants file

Status in neutron:
  Fix Released

Bug description:
  The DHCP client and server port numbers are incorrectly defined in the
  constants file:

  DHCP_CLIENT_PORT = 67
  DHCP_RESPONSE_PORT = 68

  IANA defines these the opposite - 68 for the client and 67 for the
  server.

  Neutron uses them backwards, so will also need an update to work-
  around so a new release of neutron-lib doesn't break things.

  Also, other plugins seemed to have noticed and worked around this
  already, at least Dragonflow and Cisco have defined them correctly
  locally:

  http://codesearch.openstack.org/?q=DHCP_CLIENT_PORT&i=nope&files=&repos=

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1882588/+subscriptions


References