← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1882724] Re: OVN Octavia driver: driver shouldn't update status to octavia in case of VIP creation failure, when the vip is owned by other LB

 

Reviewed:  https://review.opendev.org/734634
Committed: https://git.openstack.org/cgit/openstack/ovn-octavia-provider/commit/?id=ac4d0272a824da72427bebb4db92e61f4cd4b302
Submitter: Zuul
Branch:    master

commit ac4d0272a824da72427bebb4db92e61f4cd4b302
Author: Maciej Jozefczyk <mjozefcz@xxxxxxxxxx>
Date:   Tue Jun 9 13:13:47 2020 +0000

    Do not send status update in case of IpAddressAlreadyAllocated
    
    If IpAddressAlreadyAllocated is raised and the created VIP with
    the same IP address allocated is not owned by LB that we're trying
    to create, we should raise DriverError instead passing the status
    update to Octavia API.
    
    Change-Id: Id0dc8a478b903b80cf8afdfa3d2b23e90d22e112
    Closes-Bug: 1882724


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1882724

Title:
  OVN Octavia driver:  driver shouldn't update status to octavia in case
  of VIP creation failure, when the vip is owned by other LB

Status in neutron:
  Fix Released

Bug description:
  While there is a VIP port already created and used by other LB
  (Amphorea), which in different thread is going to be deleted, and
  second thread tries to re-use the same IP address as previous VIP, the
  OVN LB sends the update_status_to_octavia() instead fail with driver
  error.

  Example:
  https://github.com/openstack/networking-ovn/blob/stable/train/networking_ovn/octavia/ovn_driver.py#L1811

  It causes some strange Octavia API behavior.

  Example log:

  http://paste.openstack.org/show/794494/

  
  The OVN Octavia provider should do the same as Amphorea provider:
  https://github.com/openstack/octavia/blob/master/octavia/api/drivers/amphora_driver/v2/driver.py#L77

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1882724/+subscriptions


References