← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1884512] Re: [QoS] Race condition during port qos rules deletion

 

Reviewed:  https://review.opendev.org/737247
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=e2d1c2869a2c8883157d29cf47d7a5236e63dbc1
Submitter: Zuul
Branch:    master

commit e2d1c2869a2c8883157d29cf47d7a5236e63dbc1
Author: Rodolfo Alonso Hernandez <ralonsoh@xxxxxxxxxx>
Date:   Mon Jun 22 09:47:51 2020 +0000

    [OVS] Make QoS OVS agent deletion operations more resilient
    
    When a Port is deleted, the QoS extension will reset any rule (QoS
    and Queue registers) applied on this port or will reset the
    related Interface policing parameters.
    
    If the Port and the related Interface are deleted during the QoS
    extension operation, those commands will fail. This patch makes those
    operations more resiliant by not checking the errors when writing on
    the Port or the Interface register.
    
    Change-Id: I2cc4cdf5be25fab6adbc64acabb3fffebb693fa6
    Closes-Bug: #1884512


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1884512

Title:
  [QoS] Race condition during port qos rules deletion

Status in neutron:
  Fix Released

Bug description:
  Deployment using OVS as network backend. QoS enabled.

  During the port deletion, the QoS OVS agent extension removes the
  possible QoS rules applied on a port (max BW egress/ingress, min BW
  egress/ingress).

  During this process, in "delete_ingress_bw_limit_for_port", the port
  is checked and then, if exists, it is modified to delete the QoS
  reference (clear "qos" column in "port" DB register).

  As seen in [1], the port can be deleted between both operations
  (retrieval, modification), resulting in an error.

  [1]http://paste.openstack.org/show/795047/

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1884512/+subscriptions


References