yahoo-eng-team team mailing list archive

[OpenStack Infra <1883559@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/735613
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=26f6b90930509314cece4c237e4280b60bae278f
Submitter: Zuul
Branch:    master

commit 26f6b90930509314cece4c237e4280b60bae278f
Author: Lucas Alvares Gomes <lucasagomes@xxxxxxxxx>
Date:   Mon Jun 15 11:45:19 2020 +0100

    [OVN] OVN driver to adapt to enable_distributed_floating_ip changes
    
    Prior to this patch, if the [ovn]/enable_distributed_floating_ip
    configuration option changed in an existing environment the OVN
    driver wouldn't adapt to it requiring administrators to clear up the
    "external_mac" column from the NAT table manually for the existing
    floating ips.
    
    With this patch, OVN will automatically correct existing NAT entries for
    floating ips whenever this option changes.
    
    To make the code simpler when handling the port up/down event this patch
    always set the logical_port and the neutron:fip_external_mac key in the
    external_ids column of the NAT entry when creating the floating ip.
    
    Note that we are not using the maintenance task for this either, we are
    re-using the event that set/unset the "external_mac" column for this
    because, whenenver the service is restarted (after the configuration is
    changed, we need to restart for it to take effect) the IDL will re-trigger
    those events.
    
    Closes-Bug: #1883559
    Change-Id: I6a85fdde2558d781bf2853c5d11c5c964bbab81f
    Signed-off-by: Lucas Alvares Gomes <lucasagomes@xxxxxxxxx>


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1883559

Title:
  [OVN] enable_distributed_floating_ip changes are not applied for
  existing NAT entries

Status in neutron:
  Fix Released

Bug description:
  In OVN, if we change the value of the
  [ovn]/enable_distributed_floating_ip configuration option and restart
  the service, the OVN driver will not reflect this change in the
  existing NAT entries.

  Say you have a enable_distributed_floating_ip as True and then you
  change it to False, new NAT entries (floating ips) will have the
  "external_mac" column empty when they are created but, pre-existing
  NAT entries won't be updated and will have their "external_mac" set.
  Requiring someone to manually update the OVN database to clear out
  that field.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1883559/+subscriptions