yahoo-eng-team team mailing list archive

[Rodolfo Alonso <1886542@xxxxxxxxxxxxxxxxxx>]

Sorry, my bad. This is what log reports but the transaction resolves the
insertion and returns the UUID of the register added.

** Changed in: neutron
       Status: New => Invalid

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1886542

Title:
  [QoS] OVSBridge QoS BW limit operations insert return transaction
  objects instead of object UUIDs

Status in neutron:
  Invalid

Bug description:
  Some OVSBridge QoS functions do not return what is expected. For
  example [1] does not return the queue UUID but the transaction object.
  E.g.: [2] the queue UUID expected is added to the "queues" field of a
  QoS register. The DbCreateCommand object description string is added
  instead.

  2020-07-06 12:33:37.329 16211 DEBUG
  ovsdbapp.backend.ovs_idl.transaction [req-6694bb42-c42b-
  4efd-b913-b96553f79aaa - - - - -] Running txn n=1 command(idx=1):
  DbCreateCommand(table=QoS, columns={'external_ids': {'id':
  'porta12c45'}, 'type': 'linux-htb', 'queues': {0:
  <ovsdbapp.backend.ovs_idl.command.DbCreateCommand object at
  0x7f1c921f4c18>}, 'other_config': {'max-rate': '500000'}}, row=False)
  do_commit /home/zuul/src/opendev.org/openstack/neutron/.tox/dsvm-
  fullstack-gate/lib/python3.6/site-
  packages/ovsdbapp/backend/ovs_idl/transaction.py:87

  Using ovsdbapp allows to execute individually each operation and
  return the new created register, as a RowView object. That will
  provide the UUDI needed.

  
  [1]https://github.com/openstack/neutron/blob/d37c9259c754ec5f2b1dc828a05a556e1b8d74d6/neutron/agent/common/ovs_lib.py#L774-L778
  [2]https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_ebc/737047/9/check/neutron-fullstack/ebc8e9c/controller/logs/dsvm-fullstack-logs/TestBwLimitQoSOvs.test_bw_limit_qos_rules_changed_l2_agent_restart_egress_/neutron-openvswitch-agent--2020-07-06--12-33-23-312364_log.txt

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1886542/+subscriptions