← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1889676] Re: "stores" can be set as property breaking multistore indication of stores where the images are present

 

Reviewed:  https://review.opendev.org/744030
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=e1f0e94b90b162b1cdca5bdd7af3c09a90ca80ac
Submitter: Zuul
Branch:    master

commit e1f0e94b90b162b1cdca5bdd7af3c09a90ca80ac
Author: Erno Kuvaja <jokke@xxxxxx>
Date:   Thu Jul 30 19:37:53 2020 +0100

    Add "stores" to disallowed properties
    
    Stores is image property which API uses to indicate which
    stores (store IDs) contains the image. This also can be
    set by user making it very confusing and potentially
    catastrophic breaking for consumers.
    
    This patch prevents that to happen.
    
    Depends-on: https://review.opendev.org/#/c/744024/
    Change-Id: I4eca092bd0a7cce1d6bbbd30685f4643cb4e7d1c
    Closes-Bug: #1889676


** Changed in: glance
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1889676

Title:
  "stores" can be set as property breaking multistore indication of
  stores where the images are present

Status in Glance:
  Fix Released
Status in Glance train series:
  New
Status in Glance ussuri series:
  New
Status in Glance victoria series:
  Fix Released

Bug description:
  Glance API happily accepts `glance image-create --property
  stores:test1,test2` while stores is reserved for indication in which
  store IDs the image is actually present.

  For the fix we need client patch [0] merged and released.

  [0] https://review.opendev.org/#/c/744024/

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1889676/+subscriptions


References