yahoo-eng-team team mailing list archive

[OpenStack Infra <1889640@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/744011
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=b985e44f795340edfceed3b46abf9b4b28907cbb
Submitter: Zuul
Branch:    master

commit b985e44f795340edfceed3b46abf9b4b28907cbb
Author: Erno Kuvaja <jokke@xxxxxx>
Date:   Thu Jul 30 17:20:36 2020 +0100

    Fix active image without data
    
    Fixes image import resulting active image without any data
    when the image happens to be deleted from staging before
    _DeleteFromFS task is ran which is supposed to cleanup.
    
    Change-Id: I6256a25d1907ec15fbdde560fc8eae37f3067213
    Closes-Bug: #1889640


** Changed in: glance
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1889640

Title:
  Image import might result 'active' image with no data.

Status in Glance:
  Fix Released
Status in Glance ussuri series:
  In Progress
Status in Glance victoria series:
  Fix Released

Bug description:
  There is two scenarios where Interoperable Image Import might result
  'Active' image without image data in it.

  1) If the data from staging was deleted by the time task tries to delete it.
      * In This scenario the taskflow will hit revert chain, delete the image from the stores it had just uploaded, but will not revert the set_image_data() changing the image to active.

  2) If the 'all_stores_must_succeed' was set to 'false' and all uploads fails.
      * As we ignore the individual store failures in this scenario the taskflow will finish and when it gets to _SaveImage it will finally set the image active even we have no locations.

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1889640/+subscriptions